* [PATCH RESEND] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA
@ 2024-06-24 1:56 Liu Ying
2024-06-24 8:49 ` neil.armstrong
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Liu Ying @ 2024-06-24 1:56 UTC (permalink / raw)
To: dri-devel, linux-kernel
Cc: neil.armstrong, quic_jesszhan, sam, maarten.lankhorst, mripard,
tzimmermann, airlied, daniel, victor.liu, emil.l.velikov
KOE TX26D202VM0BWA panel spec indicates the DE signal is active high in
timing chart, so add DISPLAY_FLAGS_DE_HIGH flag in display timing flags.
This aligns display_timing with panel_desc.
Fixes: 8a07052440c2 ("drm/panel: simple: Add support for KOE TX26D202VM0BWA panel")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
drivers/gpu/drm/panel/panel-simple.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 20e3df1c59d4..7b70606e5760 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2704,6 +2704,7 @@ static const struct display_timing koe_tx26d202vm0bwa_timing = {
.vfront_porch = { 3, 5, 10 },
.vback_porch = { 2, 5, 10 },
.vsync_len = { 5, 5, 5 },
+ .flags = DISPLAY_FLAGS_DE_HIGH,
};
static const struct panel_desc koe_tx26d202vm0bwa = {
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA
2024-06-24 1:56 [PATCH RESEND] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA Liu Ying
@ 2024-06-24 8:49 ` neil.armstrong
2024-06-24 21:51 ` Jessica Zhang
2024-06-25 9:49 ` Neil Armstrong
2 siblings, 0 replies; 4+ messages in thread
From: neil.armstrong @ 2024-06-24 8:49 UTC (permalink / raw)
To: Liu Ying, dri-devel, linux-kernel
Cc: quic_jesszhan, sam, maarten.lankhorst, mripard, tzimmermann,
airlied, daniel, emil.l.velikov
On 24/06/2024 03:56, Liu Ying wrote:
> KOE TX26D202VM0BWA panel spec indicates the DE signal is active high in
> timing chart, so add DISPLAY_FLAGS_DE_HIGH flag in display timing flags.
> This aligns display_timing with panel_desc.
>
> Fixes: 8a07052440c2 ("drm/panel: simple: Add support for KOE TX26D202VM0BWA panel")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 20e3df1c59d4..7b70606e5760 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2704,6 +2704,7 @@ static const struct display_timing koe_tx26d202vm0bwa_timing = {
> .vfront_porch = { 3, 5, 10 },
> .vback_porch = { 2, 5, 10 },
> .vsync_len = { 5, 5, 5 },
> + .flags = DISPLAY_FLAGS_DE_HIGH,
> };
>
> static const struct panel_desc koe_tx26d202vm0bwa = {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA
2024-06-24 1:56 [PATCH RESEND] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA Liu Ying
2024-06-24 8:49 ` neil.armstrong
@ 2024-06-24 21:51 ` Jessica Zhang
2024-06-25 9:49 ` Neil Armstrong
2 siblings, 0 replies; 4+ messages in thread
From: Jessica Zhang @ 2024-06-24 21:51 UTC (permalink / raw)
To: Liu Ying, dri-devel, linux-kernel
Cc: neil.armstrong, sam, maarten.lankhorst, mripard, tzimmermann,
airlied, daniel, emil.l.velikov
On 6/23/2024 6:56 PM, Liu Ying wrote:
> KOE TX26D202VM0BWA panel spec indicates the DE signal is active high in
> timing chart, so add DISPLAY_FLAGS_DE_HIGH flag in display timing flags.
> This aligns display_timing with panel_desc.
>
> Fixes: 8a07052440c2 ("drm/panel: simple: Add support for KOE TX26D202VM0BWA panel")
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 20e3df1c59d4..7b70606e5760 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -2704,6 +2704,7 @@ static const struct display_timing koe_tx26d202vm0bwa_timing = {
> .vfront_porch = { 3, 5, 10 },
> .vback_porch = { 2, 5, 10 },
> .vsync_len = { 5, 5, 5 },
> + .flags = DISPLAY_FLAGS_DE_HIGH,
> };
>
> static const struct panel_desc koe_tx26d202vm0bwa = {
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA
2024-06-24 1:56 [PATCH RESEND] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA Liu Ying
2024-06-24 8:49 ` neil.armstrong
2024-06-24 21:51 ` Jessica Zhang
@ 2024-06-25 9:49 ` Neil Armstrong
2 siblings, 0 replies; 4+ messages in thread
From: Neil Armstrong @ 2024-06-25 9:49 UTC (permalink / raw)
To: dri-devel, linux-kernel, Liu Ying
Cc: quic_jesszhan, sam, maarten.lankhorst, mripard, tzimmermann,
airlied, daniel, emil.l.velikov
Hi,
On Mon, 24 Jun 2024 09:56:12 +0800, Liu Ying wrote:
> KOE TX26D202VM0BWA panel spec indicates the DE signal is active high in
> timing chart, so add DISPLAY_FLAGS_DE_HIGH flag in display timing flags.
> This aligns display_timing with panel_desc.
>
>
Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)
[1/1] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/37ce99b77762256ec9fda58d58fd613230151456
--
Neil
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-25 9:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-06-24 1:56 [PATCH RESEND] drm/panel: simple: Add missing display timing flags for KOE TX26D202VM0BWA Liu Ying
2024-06-24 8:49 ` neil.armstrong
2024-06-24 21:51 ` Jessica Zhang
2024-06-25 9:49 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®