From: Michal Luczaj <mhal@rbox.co>
To: Jiayuan Chen <mrpre@163.com>
Cc: Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Mykola Lysenko <mykolal@fb.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
bpf@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Jakub Sitnicki <jakub@cloudflare.com>
Subject: Re: [PATCH bpf-next v2 5/9] selftests/bpf: Add selftest for sockmap/hashmap redirection
Date: Wed, 16 Apr 2025 14:32:44 +0200 [thread overview]
Message-ID: <d81e3e32-55f7-4764-aac8-ec959ae87175@rbox.co> (raw)
In-Reply-To: <ckmjezlvp565ndplzmjmezvh6yc5enlxjgzcyd6uhn7trbuyxn@x56gl73w3mfm>
On 4/11/25 15:17, Jiayuan Chen wrote:
> On Fri, Apr 11, 2025 at 01:32:41PM +0200, Michal Luczaj wrote:
>> Test redirection logic. All supported and unsupported redirect combinations
>> are tested for success and failure respectively.
>> ...
>> + for (r = redirs; r < redirs + ARRAY_SIZE(redirs); r++) {
>> + enum bpf_attach_type attach_type;
>> + struct test_sockmap_listen *skel;
>
> Could we create a new BPF program file, such as test_sockmap_redir.c,
> instead of reusing existing ones? This file would be specifically
> dedicated to serving the sockmap_redir.c functionality.
>
> I understand there are already some duplicate programs, but isn’t this
> exactly the goal of our current work—to make the test examples more
> comprehensive and cleaner?
Sure, I get your point. I'll do that.
Thanks,
Michal
next prev parent reply other threads:[~2025-04-16 12:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 11:32 [PATCH bpf-next v2 0/9] selftests/bpf: Test sockmap/sockhash redirection Michal Luczaj
2025-04-11 11:32 ` [PATCH bpf-next v2 1/9] selftests/bpf: Support af_unix SOCK_DGRAM socket pair creation Michal Luczaj
2025-04-18 16:07 ` Jakub Sitnicki
2025-04-11 11:32 ` [PATCH bpf-next v2 2/9] selftests/bpf: Add socket_kind_to_str() to socket_helpers Michal Luczaj
2025-04-18 16:08 ` Jakub Sitnicki
2025-04-11 11:32 ` [PATCH bpf-next v2 3/9] selftests/bpf: Add u32()/u64() to sockmap_helpers Michal Luczaj
2025-04-18 16:13 ` Jakub Sitnicki
2025-04-11 11:32 ` [PATCH bpf-next v2 4/9] selftests/bpf: Allow setting BPF_F_INGRESS in prog_msg_verdict() Michal Luczaj
2025-04-11 11:32 ` [PATCH bpf-next v2 5/9] selftests/bpf: Add selftest for sockmap/hashmap redirection Michal Luczaj
2025-04-11 13:09 ` Jiayuan Chen
2025-04-11 17:54 ` Jakub Sitnicki
2025-04-16 12:33 ` Michal Luczaj
2025-04-11 13:17 ` Jiayuan Chen
2025-04-16 12:32 ` Michal Luczaj [this message]
2025-04-11 14:31 ` Jiayuan Chen
2025-04-16 12:33 ` Michal Luczaj
2025-04-11 11:32 ` [PATCH bpf-next v2 6/9] selftests/bpf: sockmap_listen cleanup: Drop af_vsock redir tests Michal Luczaj
2025-04-11 11:32 ` [PATCH bpf-next v2 7/9] selftests/bpf: sockmap_listen cleanup: Drop af_unix " Michal Luczaj
2025-04-11 11:32 ` [PATCH bpf-next v2 8/9] selftests/bpf: sockmap_listen cleanup: Drop af_inet SOCK_DGRAM " Michal Luczaj
2025-04-11 11:32 ` [PATCH bpf-next v2 9/9] docs/bpf: sockmap: Add a missing comma Michal Luczaj
2025-04-11 13:06 ` [PATCH bpf-next v2 0/9] selftests/bpf: Test sockmap/sockhash redirection Jiayuan Chen
2025-04-21 4:20 ` John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d81e3e32-55f7-4764-aac8-ec959ae87175@rbox.co \
--to=mhal@rbox.co \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mrpre@163.com \
--cc=mykolal@fb.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®