From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>,
andi.shyti@kernel.org, broonie@kernel.org,
alim.akhtar@samsung.com, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] spi: s3c64xx: Fix module autoloading
Date: Mon, 19 Aug 2024 07:57:40 +0200 [thread overview]
Message-ID: <d824b057-4cdb-4dd8-992a-152d64173f33@kernel.org> (raw)
In-Reply-To: <20240819040523.2801461-1-ruanjinjie@huawei.com>
On 19/08/2024 06:05, Jinjie Ruan wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> drivers/spi/spi-s3c64xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 833c58c88e40..51a002b3f518 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -1637,6 +1637,7 @@ static const struct platform_device_id s3c64xx_spi_driver_ids[] = {
> },
> { },
> };
> +MODULE_DEVICE_TABLE(platform, s3c64xx_spi_driver_ids);
We plan to drop the last remaining platform users of this driver, but so
far it's indeed correct.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-19 5:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 4:05 Jinjie Ruan
2024-08-19 5:57 ` Krzysztof Kozlowski [this message]
2024-08-19 18:39 ` Andi Shyti
2024-08-19 18:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d824b057-4cdb-4dd8-992a-152d64173f33@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome