* [PATCH -next] spi: s3c64xx: Fix module autoloading
@ 2024-08-19 4:05 Jinjie Ruan
2024-08-19 5:57 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jinjie Ruan @ 2024-08-19 4:05 UTC (permalink / raw)
To: andi.shyti, broonie, krzk, alim.akhtar, linux-spi, linux-kernel
Cc: ruanjinjie
Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
based on the alias from of_device_id table.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/spi/spi-s3c64xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
index 833c58c88e40..51a002b3f518 100644
--- a/drivers/spi/spi-s3c64xx.c
+++ b/drivers/spi/spi-s3c64xx.c
@@ -1637,6 +1637,7 @@ static const struct platform_device_id s3c64xx_spi_driver_ids[] = {
},
{ },
};
+MODULE_DEVICE_TABLE(platform, s3c64xx_spi_driver_ids);
static const struct of_device_id s3c64xx_spi_dt_match[] = {
{ .compatible = "google,gs101-spi",
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] spi: s3c64xx: Fix module autoloading
2024-08-19 4:05 [PATCH -next] spi: s3c64xx: Fix module autoloading Jinjie Ruan
@ 2024-08-19 5:57 ` Krzysztof Kozlowski
2024-08-19 18:39 ` Andi Shyti
2024-08-19 18:45 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-19 5:57 UTC (permalink / raw)
To: Jinjie Ruan, andi.shyti, broonie, alim.akhtar, linux-spi, linux-kernel
On 19/08/2024 06:05, Jinjie Ruan wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> drivers/spi/spi-s3c64xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c
> index 833c58c88e40..51a002b3f518 100644
> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -1637,6 +1637,7 @@ static const struct platform_device_id s3c64xx_spi_driver_ids[] = {
> },
> { },
> };
> +MODULE_DEVICE_TABLE(platform, s3c64xx_spi_driver_ids);
We plan to drop the last remaining platform users of this driver, but so
far it's indeed correct.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] spi: s3c64xx: Fix module autoloading
2024-08-19 4:05 [PATCH -next] spi: s3c64xx: Fix module autoloading Jinjie Ruan
2024-08-19 5:57 ` Krzysztof Kozlowski
@ 2024-08-19 18:39 ` Andi Shyti
2024-08-19 18:45 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Andi Shyti @ 2024-08-19 18:39 UTC (permalink / raw)
To: Jinjie Ruan; +Cc: broonie, krzk, alim.akhtar, linux-spi, linux-kernel
Hi Jinjie,
On Mon, Aug 19, 2024 at 12:05:23PM GMT, Jinjie Ruan wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Thanks,
Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] spi: s3c64xx: Fix module autoloading
2024-08-19 4:05 [PATCH -next] spi: s3c64xx: Fix module autoloading Jinjie Ruan
2024-08-19 5:57 ` Krzysztof Kozlowski
2024-08-19 18:39 ` Andi Shyti
@ 2024-08-19 18:45 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2024-08-19 18:45 UTC (permalink / raw)
To: andi.shyti, krzk, alim.akhtar, linux-spi, linux-kernel, Jinjie Ruan
On Mon, 19 Aug 2024 12:05:23 +0800, Jinjie Ruan wrote:
> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded
> based on the alias from of_device_id table.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: s3c64xx: Fix module autoloading
commit: aa6e8296a7ff55c7c40a616b87c521b2a7e96395
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-19 18:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-19 4:05 [PATCH -next] spi: s3c64xx: Fix module autoloading Jinjie Ruan
2024-08-19 5:57 ` Krzysztof Kozlowski
2024-08-19 18:39 ` Andi Shyti
2024-08-19 18:45 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome