From: Guenter Roeck <linux@roeck-us.net>
To: Matt Redfearn <matt.redfearn@imgtec.com>,
Wim Van Sebroeck <wim@iguana.be>
Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer
Date: Mon, 12 Sep 2016 06:01:06 -0700 [thread overview]
Message-ID: <d836fe83-8daa-9e17-4eca-41331c480a24@roeck-us.net> (raw)
In-Reply-To: <1473672913-10484-1-git-send-email-matt.redfearn@imgtec.com>
On 09/12/2016 02:35 AM, Matt Redfearn wrote:
> Commit 0254e953537c ("watchdog: Drop pointer to watchdog device from
> struct watchdog_device") removed the dev pointer from struct
> watchdog_device, but this driver was still assigning it, leading to a
> compilation error:
>
> drivers/watchdog/rt2880_wdt.c: In function ‘rt288x_wdt_probe’:
> drivers/watchdog/rt2880_wdt.c:161:16: error: ‘struct watchdog_device’
> has no member named ‘dev’
> rt288x_wdt_dev.dev = &pdev->dev;
> ^
> scripts/Makefile.build:289: recipe for target
> 'drivers/watchdog/rt2880_wdt.o' failed
>
> Fix this by removing the assignment.
>
> Fixes: 0254e953537c
Fixes: 0254e953537c ("watchdog: Drop pointer to watchdog device ...")
> Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Cc: stable@vger.kernel.org # v4.5+
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
>
> drivers/watchdog/rt2880_wdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/watchdog/rt2880_wdt.c b/drivers/watchdog/rt2880_wdt.c
> index 1967919ae743..14b4fd428fff 100644
> --- a/drivers/watchdog/rt2880_wdt.c
> +++ b/drivers/watchdog/rt2880_wdt.c
> @@ -158,7 +158,6 @@ static int rt288x_wdt_probe(struct platform_device *pdev)
>
> rt288x_wdt_freq = clk_get_rate(rt288x_wdt_clk) / RALINK_WDT_PRESCALE;
>
> - rt288x_wdt_dev.dev = &pdev->dev;
> rt288x_wdt_dev.bootstatus = rt288x_wdt_bootcause();
> rt288x_wdt_dev.max_timeout = (0xfffful / rt288x_wdt_freq);
> rt288x_wdt_dev.parent = &pdev->dev;
>
next prev parent reply other threads:[~2016-09-12 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 9:35 Matt Redfearn
2016-09-12 13:01 ` Guenter Roeck [this message]
2016-10-08 14:03 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d836fe83-8daa-9e17-4eca-41331c480a24@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=matt.redfearn@imgtec.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®