* [PATCH] media: raspberrypi: Remove redundant "no IRQ" message
@ 2024-10-18 14:24 Ricardo Ribalda
2024-10-28 9:28 ` Tomi Valkeinen
0 siblings, 1 reply; 2+ messages in thread
From: Ricardo Ribalda @ 2024-10-18 14:24 UTC (permalink / raw)
To: Tomi Valkeinen, Raspberry Pi Kernel Maintenance,
Mauro Carvalho Chehab, Florian Fainelli,
Broadcom internal kernel review list
Cc: linux-media, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
Ricardo Ribalda
platform_get_irq() already provides a error message.
This fixes the following cocci error:
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c:2326:2-9: line 2326 is redundant because platform_get_irq() already prints an error
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
index 045910de6c57..4e99cccd9a20 100644
--- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
+++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
@@ -2323,7 +2323,6 @@ static int cfe_probe(struct platform_device *pdev)
ret = platform_get_irq(pdev, 0);
if (ret <= 0) {
- dev_err(&pdev->dev, "No IRQ resource\n");
ret = -EINVAL;
goto err_cfe_put;
}
---
base-commit: 698b6e3163bafd61e1b7d13572e2c42974ac85ec
change-id: 20241018-rpi-irq-cocci-878e4a82ea2c
Best regards,
--
Ricardo Ribalda <ribalda@chromium.org>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] media: raspberrypi: Remove redundant "no IRQ" message
2024-10-18 14:24 [PATCH] media: raspberrypi: Remove redundant "no IRQ" message Ricardo Ribalda
@ 2024-10-28 9:28 ` Tomi Valkeinen
0 siblings, 0 replies; 2+ messages in thread
From: Tomi Valkeinen @ 2024-10-28 9:28 UTC (permalink / raw)
To: Ricardo Ribalda, Raspberry Pi Kernel Maintenance,
Mauro Carvalho Chehab, Florian Fainelli,
Broadcom internal kernel review list
Cc: linux-media, linux-rpi-kernel, linux-arm-kernel, linux-kernel
Hi,
On 18/10/2024 17:24, Ricardo Ribalda wrote:
> platform_get_irq() already provides a error message.
>
> This fixes the following cocci error:
> drivers/media/platform/raspberrypi/rp1-cfe/cfe.c:2326:2-9: line 2326 is redundant because platform_get_irq() already prints an error
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> index 045910de6c57..4e99cccd9a20 100644
> --- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> +++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> @@ -2323,7 +2323,6 @@ static int cfe_probe(struct platform_device *pdev)
>
> ret = platform_get_irq(pdev, 0);
> if (ret <= 0) {
> - dev_err(&pdev->dev, "No IRQ resource\n");
> ret = -EINVAL;
> goto err_cfe_put;
> }
>
> ---
> base-commit: 698b6e3163bafd61e1b7d13572e2c42974ac85ec
> change-id: 20241018-rpi-irq-cocci-878e4a82ea2c
>
> Best regards,
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-28 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-18 14:24 [PATCH] media: raspberrypi: Remove redundant "no IRQ" message Ricardo Ribalda
2024-10-28 9:28 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®