From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>, <hdegoede@redhat.com>,
<axboe@kernel.dk>, <p.zabel@pengutronix.de>
Cc: <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ata: libahci_platform: Remove abundant check
Date: Thu, 23 Dec 2021 12:31:06 +0300 [thread overview]
Message-ID: <d879552f-3085-91e6-77fa-d391b890fb6b@omp.ru> (raw)
In-Reply-To: <20211222072446.1096168-1-jiasheng@iscas.ac.cn>
Hello!
On 22.12.2021 10:24, Jiasheng Jiang wrote:
> It can be found that platform_get_irq() returns nagative code but not
> null when fails.
s/null/zero/?
> The comment of the platform_get_irq clearly shows that.
This comment still doesn't correspond to reality -- 0 can be returned
(although this would cause a WARN() call)...
> Therefore it should be better to remove the useless check.
This patch is correct but premature. I have a (not yet merged) patch:
https://marc.info/?l=linux-kernel&m=163623041902285
It actually disables reporting IRQ0. Until it's merged we have to filter
out IRQ0 in the libata drivers as libata treats 0 as an indication of the
polling mode...
> Fixes: fd990556f0fa ("ata: move library code from ahci_platform.c to libahci_platform.c")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
[...]
MBR, Sergey
prev parent reply other threads:[~2021-12-23 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 7:24 Jiasheng Jiang
2021-12-23 0:41 ` Damien Le Moal
2021-12-23 0:44 ` Damien Le Moal
2021-12-23 9:31 ` Sergey Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d879552f-3085-91e6-77fa-d391b890fb6b@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=axboe@kernel.dk \
--cc=hdegoede@redhat.com \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®