From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Jiasheng Jiang <jiasheng@iscas.ac.cn>,
hdegoede@redhat.com, axboe@kernel.dk, p.zabel@pengutronix.de
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: libahci_platform: Remove abundant check
Date: Thu, 23 Dec 2021 09:41:54 +0900 [thread overview]
Message-ID: <dd6e6054-3d7e-b43a-0386-71323c49ab27@opensource.wdc.com> (raw)
In-Reply-To: <20211222072446.1096168-1-jiasheng@iscas.ac.cn>
On 12/22/21 16:24, Jiasheng Jiang wrote:
> It can be found that platform_get_irq() returns nagative code but not
> null when fails.
> The comment of the platform_get_irq clearly shows that.
> Therefore it should be better to remove the useless check.
Nope, platform_get_irq() can actually return 0 (the comment for that
function is wrong). So testing for !irq is valid and must be kept.
>
> Fixes: fd990556f0fa ("ata: move library code from ahci_platform.c to libahci_platform.c")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> ---
> drivers/ata/libahci_platform.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
> index b2f552088291..5ec68f138c28 100644
> --- a/drivers/ata/libahci_platform.c
> +++ b/drivers/ata/libahci_platform.c
> @@ -587,8 +587,6 @@ int ahci_platform_init_host(struct platform_device *pdev,
> dev_err(dev, "no irq\n");
> return irq;
> }
> - if (!irq)
> - return -EINVAL;
>
> hpriv->irq = irq;
>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2021-12-23 0:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 7:24 Jiasheng Jiang
2021-12-23 0:41 ` Damien Le Moal [this message]
2021-12-23 0:44 ` Damien Le Moal
2021-12-23 9:31 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd6e6054-3d7e-b43a-0386-71323c49ab27@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=axboe@kernel.dk \
--cc=hdegoede@redhat.com \
--cc=jiasheng@iscas.ac.cn \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®