From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, linux-wireless@vger.kernel.org,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steve Caldwell <Steve.Caldwell@microchip.com>
Subject: Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl()
Date: Tue, 26 Jul 2016 08:25:54 +0200 [thread overview]
Message-ID: <d8d9729c-6d65-a901-1b29-c0b031e143d2@users.sourceforge.net> (raw)
In-Reply-To: <1c4cac35-dded-ea88-45aa-3f8ac098289d@gmx.de>
>> - if (strncasecmp(buff, "RSSI", length) == 0) {
>> + if (strncasecmp(buff, "RSSI", 0) == 0) {
>> + s8 rssi;
>> +
>
> Um, please think a second about if it makes any sense at all to compare
> zero chars of two strings.
Under which circumstances should the variable "length" contain an other
value than zero?
How can this open issue be fixed better?
Regards,
Markus
next prev parent reply other threads:[~2016-07-26 6:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 19:17 [PATCH 3/3] " Lino Sanfilippo
2016-07-25 19:32 ` walter harms
2016-07-26 6:25 ` SF Markus Elfring [this message]
2016-07-28 11:45 ` Aw: " Lino Sanfilippo
2016-07-28 16:00 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8d9729c-6d65-a901-1b29-c0b031e143d2@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=LinoSanfilippo@gmx.de \
--cc=Steve.Caldwell@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome