From: Jonathan Cameron <jic23@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Mugunthan V N <mugunthanvnm@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: TI_AM335X_ADC should depend on HAS_DMA
Date: Fri, 30 Dec 2016 16:39:20 +0000 [thread overview]
Message-ID: <d8fc53e7-ee27-58f0-a117-190753079869@kernel.org> (raw)
In-Reply-To: <1481718624-7238-1-git-send-email-geert@linux-m68k.org>
On 14/12/16 12:30, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> ERROR: "bad_dma_ops" [drivers/iio/adc/ti_am335x_adc.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to the fixes-togreg-post-rc1 branch of iio.git (will unwind
this fun branch shortly now we are post rc1) and marked for stable
with an appropriate fixes tag added.
Thanks,
Jonathan
> ---
> drivers/iio/adc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 38bc319904c4c299..9c8b558ba19ecb03 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -561,7 +561,7 @@ config TI_ADS8688
>
> config TI_AM335X_ADC
> tristate "TI's AM335X ADC driver"
> - depends on MFD_TI_AM335X_TSCADC
> + depends on MFD_TI_AM335X_TSCADC && HAS_DMA
> select IIO_BUFFER
> select IIO_KFIFO_BUF
> help
>
prev parent reply other threads:[~2016-12-30 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 12:30 Geert Uytterhoeven
2016-12-30 16:39 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8fc53e7-ee27-58f0-a117-190753079869@kernel.org \
--to=jic23@kernel.org \
--cc=geert@linux-m68k.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mugunthanvnm@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®