* [PATCH v6 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET
@ 2021-01-14 6:54 Yu-Hsuan Hsu
2021-01-14 6:54 ` [PATCH v6 2/2] ASoC: cros_ec_codec: Reset I2S RX when probing Yu-Hsuan Hsu
2021-01-14 10:19 ` [PATCH v6 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET Enric Balletbo i Serra
0 siblings, 2 replies; 4+ messages in thread
From: Yu-Hsuan Hsu @ 2021-01-14 6:54 UTC (permalink / raw)
To: linux-kernel
Cc: Benson Leung, Enric Balletbo i Serra, Guenter Roeck,
Cheng-Yi Chiang, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Prashant Malani, Pi-Hsun Shih, Yu-Hsuan Hsu,
Gustavo A . R . Silva, alsa-devel
Add the new command EC_CODEC_I2S_RX_RESET in ec_codec_i2s_rx_subcmd,
which is used for resetting the EC codec.
Signed-off-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
---
include/linux/platform_data/cros_ec_commands.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
index 86376779ab31..95889ada83a3 100644
--- a/include/linux/platform_data/cros_ec_commands.h
+++ b/include/linux/platform_data/cros_ec_commands.h
@@ -4600,6 +4600,7 @@ enum ec_codec_i2s_rx_subcmd {
EC_CODEC_I2S_RX_SET_SAMPLE_DEPTH = 0x2,
EC_CODEC_I2S_RX_SET_DAIFMT = 0x3,
EC_CODEC_I2S_RX_SET_BCLK = 0x4,
+ EC_CODEC_I2S_RX_RESET = 0x5,
EC_CODEC_I2S_RX_SUBCMD_COUNT,
};
--
2.30.0.284.gd98b1dd5eaa7-goog
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v6 2/2] ASoC: cros_ec_codec: Reset I2S RX when probing
2021-01-14 6:54 [PATCH v6 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET Yu-Hsuan Hsu
@ 2021-01-14 6:54 ` Yu-Hsuan Hsu
2021-01-14 10:15 ` Enric Balletbo i Serra
2021-01-14 10:19 ` [PATCH v6 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET Enric Balletbo i Serra
1 sibling, 1 reply; 4+ messages in thread
From: Yu-Hsuan Hsu @ 2021-01-14 6:54 UTC (permalink / raw)
To: linux-kernel
Cc: Benson Leung, Enric Balletbo i Serra, Guenter Roeck,
Cheng-Yi Chiang, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Prashant Malani, Pi-Hsun Shih, Yu-Hsuan Hsu,
Gustavo A . R . Silva, alsa-devel
It is not guaranteed that I2S RX is disabled when the kernel booting.
For example, if the kernel crashes while it is enabled, it will keep
enabled until the next time EC reboots. Reset I2S RX when probing to
fix this issue.
Signed-off-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
---
Returns the error code when it fails to reset.
sound/soc/codecs/cros_ec_codec.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
index f33a2a9654e7..40e437aa1d55 100644
--- a/sound/soc/codecs/cros_ec_codec.c
+++ b/sound/soc/codecs/cros_ec_codec.c
@@ -1011,6 +1011,18 @@ static int cros_ec_codec_platform_probe(struct platform_device *pdev)
}
priv->ec_capabilities = r.capabilities;
+ /* Reset EC codec i2s rx. */
+ p.cmd = EC_CODEC_I2S_RX_RESET;
+ ret = send_ec_host_command(priv->ec_device, EC_CMD_EC_CODEC_I2S_RX,
+ (uint8_t *)&p, sizeof(p), NULL, 0);
+ if (ret == -ENOPROTOOPT) {
+ dev_info(dev,
+ "Command not found. Please update the EC firmware.\n");
+ } else if (ret) {
+ dev_err(dev, "failed to EC_CODEC_I2S_RESET: %d\n", ret);
+ return ret;
+ }
+
platform_set_drvdata(pdev, priv);
ret = devm_snd_soc_register_component(dev, &i2s_rx_component_driver,
--
2.30.0.284.gd98b1dd5eaa7-goog
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v6 2/2] ASoC: cros_ec_codec: Reset I2S RX when probing
2021-01-14 6:54 ` [PATCH v6 2/2] ASoC: cros_ec_codec: Reset I2S RX when probing Yu-Hsuan Hsu
@ 2021-01-14 10:15 ` Enric Balletbo i Serra
0 siblings, 0 replies; 4+ messages in thread
From: Enric Balletbo i Serra @ 2021-01-14 10:15 UTC (permalink / raw)
To: Yu-Hsuan Hsu, linux-kernel
Cc: Benson Leung, Guenter Roeck, Cheng-Yi Chiang, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Prashant Malani,
Pi-Hsun Shih, Gustavo A . R . Silva, alsa-devel
Hi Yu-Hsuan,
On 14/1/21 7:54, Yu-Hsuan Hsu wrote:
> It is not guaranteed that I2S RX is disabled when the kernel booting.
> For example, if the kernel crashes while it is enabled, it will keep
> enabled until the next time EC reboots. Reset I2S RX when probing to
> fix this issue.
>
> Signed-off-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
> ---
> Returns the error code when it fails to reset.
>
> sound/soc/codecs/cros_ec_codec.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/sound/soc/codecs/cros_ec_codec.c b/sound/soc/codecs/cros_ec_codec.c
> index f33a2a9654e7..40e437aa1d55 100644
> --- a/sound/soc/codecs/cros_ec_codec.c
> +++ b/sound/soc/codecs/cros_ec_codec.c
> @@ -1011,6 +1011,18 @@ static int cros_ec_codec_platform_probe(struct platform_device *pdev)
> }
> priv->ec_capabilities = r.capabilities;
>
> + /* Reset EC codec i2s rx. */
> + p.cmd = EC_CODEC_I2S_RX_RESET;
> + ret = send_ec_host_command(priv->ec_device, EC_CMD_EC_CODEC_I2S_RX,
> + (uint8_t *)&p, sizeof(p), NULL, 0);
> + if (ret == -ENOPROTOOPT) {
> + dev_info(dev,
> + "Command not found. Please update the EC firmware.\n");
Nitpicking a bit. I'd add which command is not found to give more information to
the user that gets into that path. Command not found is too generic for me.
But,
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> + } else if (ret) {
> + dev_err(dev, "failed to EC_CODEC_I2S_RESET: %d\n", ret);
> + return ret;
> + }
> +
> platform_set_drvdata(pdev, priv);
>
> ret = devm_snd_soc_register_component(dev, &i2s_rx_component_driver,
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v6 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET
2021-01-14 6:54 [PATCH v6 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET Yu-Hsuan Hsu
2021-01-14 6:54 ` [PATCH v6 2/2] ASoC: cros_ec_codec: Reset I2S RX when probing Yu-Hsuan Hsu
@ 2021-01-14 10:19 ` Enric Balletbo i Serra
1 sibling, 0 replies; 4+ messages in thread
From: Enric Balletbo i Serra @ 2021-01-14 10:19 UTC (permalink / raw)
To: Yu-Hsuan Hsu, linux-kernel
Cc: Benson Leung, Guenter Roeck, Cheng-Yi Chiang, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Prashant Malani,
Pi-Hsun Shih, Gustavo A . R . Silva, alsa-devel
Hi,
On 14/1/21 7:54, Yu-Hsuan Hsu wrote:
> Add the new command EC_CODEC_I2S_RX_RESET in ec_codec_i2s_rx_subcmd,
> which is used for resetting the EC codec.
>
> Signed-off-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
For if Mark wants to take this patch through his tree.
Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> include/linux/platform_data/cros_ec_commands.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
> index 86376779ab31..95889ada83a3 100644
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -4600,6 +4600,7 @@ enum ec_codec_i2s_rx_subcmd {
> EC_CODEC_I2S_RX_SET_SAMPLE_DEPTH = 0x2,
> EC_CODEC_I2S_RX_SET_DAIFMT = 0x3,
> EC_CODEC_I2S_RX_SET_BCLK = 0x4,
> + EC_CODEC_I2S_RX_RESET = 0x5,
> EC_CODEC_I2S_RX_SUBCMD_COUNT,
> };
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-14 10:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-14 6:54 [PATCH v6 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET Yu-Hsuan Hsu
2021-01-14 6:54 ` [PATCH v6 2/2] ASoC: cros_ec_codec: Reset I2S RX when probing Yu-Hsuan Hsu
2021-01-14 10:15 ` Enric Balletbo i Serra
2021-01-14 10:19 ` [PATCH v6 1/2] cros_ec_commands: Add EC_CODEC_I2S_RX_RESET Enric Balletbo i Serra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®