mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jie Gan <jie.gan@oss.qualcomm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@arm.com>,
	James Clark <james.clark@linaro.org>, Leo Yan <leo.yan@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Tingwei Zhang <tingwei.zhang@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Mao Jinlong <jinlong.mao@oss.qualcomm.com>,
	Abel Vesa <abelvesa@kernel.org>,
	Yuanfang Zhang <yuanfang.zhang@oss.qualcomm.com>
Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH v23 3/8] coresight: tmc: add a function to switch the ETR to a free etr_buf
Date: Thu, 19 Nov 2026 09:55:56 +0800	[thread overview]
Message-ID: <d94a7c66-9dba-4513-9776-2aade1e74709@oss.qualcomm.com> (raw)
In-Reply-To: <878eabf1-0742-45ad-892a-4c6a7b615d1f@arm.com>



On 11/18/2026 7:33 PM, Suzuki K Poulose wrote:
> On 18/11/2026 08:02, Jie Gan wrote:
>> Add tmc_etr_switch_buf_node() to switch the ETR to a free etr_buf of the
>> etr_buf_list without disabling the sink. It returns the node of the
>> switched out etr_buf, so its synced data can be read while the ETR keeps
>> tracing into the new one.
>>
>> Stopping the ETR, swapping the etr_buf and restarting the ETR have to be
>> done in one critical section. Otherwise tmc_disable_etr_sink() can run
>> in between and leave drvdata->etr_buf out of sync with the hardware.
>> Provide the sequence as a TMC helper, so callers don't need to know
>> about the locking of the ETR state.
>>
>> Signed-off-by: Jie Gan <jie.gan@oss.qualcomm.com>
>> ---
>>   drivers/hwtracing/coresight/coresight-tmc-etr.c | 65 +++++++++++++++ 
>> ++++++++++
>>   drivers/hwtracing/coresight/coresight-tmc.h     |  4 ++
>>   2 files changed, 69 insertions(+)
>>
>> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/ 
>> drivers/hwtracing/coresight/coresight-tmc-etr.c
>> index e9213f456834..5032f5598e15 100644
>> --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c
>> +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c
>> @@ -1224,6 +1224,71 @@ static void __tmc_etr_disable_hw(struct 
>> tmc_drvdata *drvdata)
>>   }
>> +static void tmc_etr_reset_sysfs_buf(struct tmc_drvdata *drvdata)
>> +{
>> +    u32 sts;
>> +
>> +    CS_UNLOCK(drvdata->base);
>> +    tmc_write_rrp(drvdata, drvdata->sysfs_buf->hwaddr);
>> +    tmc_write_rwp(drvdata, drvdata->sysfs_buf->hwaddr);
>> +    sts = readl_relaxed(drvdata->base + TMC_STS) & ~TMC_STS_FULL;
>> +    writel_relaxed(sts, drvdata->base + TMC_STS);
> 
> see below
> 
> 
> 
> 
>> +    CS_LOCK(drvdata->base);
>> +}
>> +
>> +/**
>> + * tmc_etr_switch_buf_node - switch the ETR to a free buffer of the 
>> etr_buf_list.
>> + * @drvdata:    drvdata of the TMC device.
>> + *
>> + * Stop the ETR, hand over the current buffer for reading, switch to 
>> a free
>> + * buffer and restart the ETR. All of this is done with @drvdata- 
>> >spinlock held,
>> + * so it can't race with the sink disable path.
>> + *
>> + * Return: the node of the switched out buffer, or NULL if the sink 
>> isn't in
>> + * sysfs mode or there is no free buffer. The ETR is left untouched 
>> in both
>> + * cases.
>> + */
>> +struct etr_buf_node *tmc_etr_switch_buf_node(struct tmc_drvdata 
>> *drvdata)
>> +{
>> +    struct etr_buf_node *nd, *curr_node = NULL, *picked_node = NULL;
>> +    unsigned long flags;
>> +
>> +    raw_spin_lock_irqsave(&drvdata->spinlock, flags);
>> +    if (coresight_get_mode(drvdata->csdev) != CS_MODE_SYSFS)
>> +        goto out;
>> +
>> +    list_for_each_entry(nd, &drvdata->etr_buf_list, link) {
>> +        if (nd->sysfs_buf == drvdata->sysfs_buf)
>> +            curr_node = nd;
>> +        else if (!picked_node && nd->is_free && !nd->reading)
>> +            picked_node = nd;
>> +    }
>> +
>> +    if (!curr_node || !picked_node) {
>> +        curr_node = NULL;
>> +        goto out;
>> +    }
>> +
>> +    __tmc_etr_disable_hw(drvdata);
>> +
>> +    /* The switched out buffer is free again once it has been read */
>> +    curr_node->is_free = true;
>> +    curr_node->pos = 0;
>> +    curr_node->reading = true;
>> +    picked_node->is_free = false;
>> +    drvdata->sysfs_buf = picked_node->sysfs_buf;
>> +    drvdata->etr_buf = picked_node->sysfs_buf;
>> +
>> +    tmc_etr_reset_sysfs_buf(drvdata);
> 
> Why are we doing this, when the following __tmc_etr_enable_hw() already 
> does the right thing ?
> 

Sorry I missed the part.

SoC-600 supports save-restore, so the __tmc_etr_enable_hw will program 
the registers properly.

SoC-400 doesnt support save-restore, driver doesnt need reset the pointers.

Everything already done properly when the driver re-start the ETR.

Thanks,
Jie

> Suzuki
> 
> 
>> +    if (__tmc_etr_enable_hw(drvdata))
>> +        dev_err(&drvdata->csdev->dev, "Failed to restart the ETR\n");
>> +out:
>> +    raw_spin_unlock_irqrestore(&drvdata->spinlock, flags);
>> +
>> +    return curr_node;
>> +}
>> +EXPORT_SYMBOL_GPL(tmc_etr_switch_buf_node);
>> +
>>   void tmc_etr_disable_hw(struct tmc_drvdata *drvdata)
>>   {
>>       __tmc_etr_disable_hw(drvdata);
>> diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/ 
>> hwtracing/coresight/coresight-tmc.h
>> index 7c604b9f92e5..30b15c38b080 100644
>> --- a/drivers/hwtracing/coresight/coresight-tmc.h
>> +++ b/drivers/hwtracing/coresight/coresight-tmc.h
>> @@ -212,12 +212,15 @@ struct tmc_resrv_buf {
>>    * struct etr_buf_node - node of the etr_buf_list
>>    * @sysfs_buf:    Allocated sysfs_buf.
>>    * @is_free:    Indicates whether the buffer is free to choose.
>> + * @reading:    Indicates the buffer attached to the node is being 
>> read by
>> + *        the user.
>>    * @pos:    Offset to the start of the buffer.
>>    * @link:    list_head of the node.
>>    */
>>   struct etr_buf_node {
>>       struct etr_buf        *sysfs_buf;
>>       bool            is_free;
>> +    bool            reading;
>>       loff_t            pos;
>>       struct list_head    link;
>>   };
>> @@ -465,5 +468,6 @@ struct etr_buf *tmc_etr_get_buffer(struct 
>> coresight_device *csdev,
>>   extern const struct attribute_group coresight_etr_group;
>>   void tmc_clean_etr_buf_list(struct tmc_drvdata *drvdata);
>>   int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int 
>> num_nodes);
>> +struct etr_buf_node *tmc_etr_switch_buf_node(struct tmc_drvdata 
>> *drvdata);
>>   #endif
>>
> 


  reply	other threads:[~2026-11-19  1:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  8:02 [PATCH v23 0/8] coresight: ctcu: Enable byte-cntr function for TMC ETR Jie Gan
2026-11-18  8:02 ` [PATCH v23 1/8] coresight: core: refactor ctcu_get_active_port and make it generic Jie Gan
2026-11-18  8:02 ` [PATCH v23 2/8] coresight: tmc: add create/clean functions for etr_buf_list Jie Gan
2026-11-18 11:16   ` Suzuki K Poulose
2026-11-19  1:46     ` Jie Gan
2026-11-18  8:02 ` [PATCH v23 3/8] coresight: tmc: add a function to switch the ETR to a free etr_buf Jie Gan
2026-11-18 11:33   ` Suzuki K Poulose
2026-11-19  1:55     ` Jie Gan [this message]
2026-11-18  8:02 ` [PATCH v23 4/8] coresight: tmc: introduce tmc_sysfs_ops to wrap sysfs read operations Jie Gan
2026-11-18  8:02 ` [PATCH v23 5/8] coresight: etr: add a new function to retrieve the CTCU device Jie Gan
2026-11-18  8:02 ` [PATCH v23 6/8] dt-bindings: arm: add an interrupt property for Coresight CTCU Jie Gan
2026-11-18  8:02 ` [PATCH v23 7/8] coresight: ctcu: enable byte-cntr for TMC ETR devices Jie Gan
2026-11-18  8:02 ` [PATCH v23 8/8] arm64: dts: qcom: lemans: add interrupts to CTCU device Jie Gan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d94a7c66-9dba-4513-9776-2aade1e74709@oss.qualcomm.com \
    --to=jie.gan@oss.qualcomm.com \
    --cc=abelvesa@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=james.clark@linaro.org \
    --cc=jinlong.mao@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=leo.yan@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mike.leach@arm.com \
    --cc=robh@kernel.org \
    --cc=suzuki.poulose@arm.com \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=yuanfang.zhang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®