* [PATCH] drm/panel: simple: Update timings for AUO G101EVN010
@ 2025-04-28 21:07 Kevin Baker
2025-05-05 7:53 ` Neil Armstrong
0 siblings, 1 reply; 7+ messages in thread
From: Kevin Baker @ 2025-04-28 21:07 UTC (permalink / raw)
To: Neil Armstrong, Sam Ravnborg
Cc: David Airlie, Daniel Vetter, dri-devel, linux-kernel, Kevin Baker
Switch to panel timings based on datasheet for the AUO G101EVN01.0
LVDS panel. Default timings were tested on the panel.
Previous mode-based timings resulted in horizontal display shift.
Signed-off-by: Kevin Baker <kevinb@ventureresearch.com>
---
drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index fb8a57afe687..1a3d7ccb328a 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -979,27 +979,28 @@ static const struct panel_desc auo_g070vvn01 = {
},
};
-static const struct drm_display_mode auo_g101evn010_mode = {
- .clock = 68930,
- .hdisplay = 1280,
- .hsync_start = 1280 + 82,
- .hsync_end = 1280 + 82 + 2,
- .htotal = 1280 + 82 + 2 + 84,
- .vdisplay = 800,
- .vsync_start = 800 + 8,
- .vsync_end = 800 + 8 + 2,
- .vtotal = 800 + 8 + 2 + 6,
+static const struct display_timing auo_g101evn010_timing = {
+ .pixelclock = { 64000000, 68930000, 85000000 },
+ .hactive = { 1280, 1280, 1280 },
+ .hfront_porch = { 8, 64, 256 },
+ .hback_porch = { 8, 64, 256 },
+ .hsync_len = { 40, 168, 767 },
+ .vactive = { 800, 800, 800 },
+ .vfront_porch = { 4, 8, 100 },
+ .vback_porch = { 4, 8, 100 },
+ .vsync_len = { 8, 16, 223 },
};
static const struct panel_desc auo_g101evn010 = {
- .modes = &auo_g101evn010_mode,
- .num_modes = 1,
+ .timings = &auo_g101evn010_timing,
+ .num_timings = 1,
.bpc = 6,
.size = {
.width = 216,
.height = 135,
},
.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH,
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};
--
2.39.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drm/panel: simple: Update timings for AUO G101EVN010
2025-04-28 21:07 [PATCH] drm/panel: simple: Update timings for AUO G101EVN010 Kevin Baker
@ 2025-05-05 7:53 ` Neil Armstrong
2025-05-05 17:02 ` [PATCH v2] " Kevin Baker
0 siblings, 1 reply; 7+ messages in thread
From: Neil Armstrong @ 2025-05-05 7:53 UTC (permalink / raw)
To: Kevin Baker, Sam Ravnborg
Cc: David Airlie, Daniel Vetter, dri-devel, linux-kernel
On 28/04/2025 23:07, Kevin Baker wrote:
> Switch to panel timings based on datasheet for the AUO G101EVN01.0
> LVDS panel. Default timings were tested on the panel.
>
> Previous mode-based timings resulted in horizontal display shift.
Can you add a Fixes tag ?
Thanks,
Neil
>
> Signed-off-by: Kevin Baker <kevinb@ventureresearch.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++------------
> 1 file changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index fb8a57afe687..1a3d7ccb328a 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -979,27 +979,28 @@ static const struct panel_desc auo_g070vvn01 = {
> },
> };
>
> -static const struct drm_display_mode auo_g101evn010_mode = {
> - .clock = 68930,
> - .hdisplay = 1280,
> - .hsync_start = 1280 + 82,
> - .hsync_end = 1280 + 82 + 2,
> - .htotal = 1280 + 82 + 2 + 84,
> - .vdisplay = 800,
> - .vsync_start = 800 + 8,
> - .vsync_end = 800 + 8 + 2,
> - .vtotal = 800 + 8 + 2 + 6,
> +static const struct display_timing auo_g101evn010_timing = {
> + .pixelclock = { 64000000, 68930000, 85000000 },
> + .hactive = { 1280, 1280, 1280 },
> + .hfront_porch = { 8, 64, 256 },
> + .hback_porch = { 8, 64, 256 },
> + .hsync_len = { 40, 168, 767 },
> + .vactive = { 800, 800, 800 },
> + .vfront_porch = { 4, 8, 100 },
> + .vback_porch = { 4, 8, 100 },
> + .vsync_len = { 8, 16, 223 },
> };
>
> static const struct panel_desc auo_g101evn010 = {
> - .modes = &auo_g101evn010_mode,
> - .num_modes = 1,
> + .timings = &auo_g101evn010_timing,
> + .num_timings = 1,
> .bpc = 6,
> .size = {
> .width = 216,
> .height = 135,
> },
> .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> };
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010
2025-05-05 7:53 ` Neil Armstrong
@ 2025-05-05 17:02 ` Kevin Baker
2025-05-06 7:42 ` Neil Armstrong
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Kevin Baker @ 2025-05-05 17:02 UTC (permalink / raw)
To: Neil Armstrong, Sam Ravnborg
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Alex Gonzalez,
Thierry Reding, Rob Herring, dri-devel, linux-kernel,
Kevin Baker
Switch to panel timings based on datasheet for the AUO G101EVN01.0
LVDS panel. Default timings were tested on the panel.
Previous mode-based timings resulted in horizontal display shift.
Signed-off-by: Kevin Baker <kevinb@ventureresearch.com>
Fixes: 4fb86404a977 ("drm/panel: simple: Add AUO G101EVN010 panel support")
---
drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index df718c4a86cb..c79dc8581054 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1026,27 +1026,28 @@ static const struct panel_desc auo_g070vvn01 = {
},
};
-static const struct drm_display_mode auo_g101evn010_mode = {
- .clock = 68930,
- .hdisplay = 1280,
- .hsync_start = 1280 + 82,
- .hsync_end = 1280 + 82 + 2,
- .htotal = 1280 + 82 + 2 + 84,
- .vdisplay = 800,
- .vsync_start = 800 + 8,
- .vsync_end = 800 + 8 + 2,
- .vtotal = 800 + 8 + 2 + 6,
+static const struct display_timing auo_g101evn010_timing = {
+ .pixelclock = { 64000000, 68930000, 85000000 },
+ .hactive = { 1280, 1280, 1280 },
+ .hfront_porch = { 8, 64, 256 },
+ .hback_porch = { 8, 64, 256 },
+ .hsync_len = { 40, 168, 767 },
+ .vactive = { 800, 800, 800 },
+ .vfront_porch = { 4, 8, 100 },
+ .vback_porch = { 4, 8, 100 },
+ .vsync_len = { 8, 16, 223 },
};
static const struct panel_desc auo_g101evn010 = {
- .modes = &auo_g101evn010_mode,
- .num_modes = 1,
+ .timings = &auo_g101evn010_timing,
+ .num_timings = 1,
.bpc = 6,
.size = {
.width = 216,
.height = 135,
},
.bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
+ .bus_flags = DRM_BUS_FLAG_DE_HIGH,
.connector_type = DRM_MODE_CONNECTOR_LVDS,
};
--
2.39.5
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010
2025-05-05 17:02 ` [PATCH v2] " Kevin Baker
@ 2025-05-06 7:42 ` Neil Armstrong
2025-05-06 11:59 ` Dmitry Baryshkov
2025-05-06 12:30 ` Neil Armstrong
2 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2025-05-06 7:42 UTC (permalink / raw)
To: Kevin Baker, Sam Ravnborg
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Alex Gonzalez,
Thierry Reding, Rob Herring, dri-devel, linux-kernel
On 05/05/2025 19:02, Kevin Baker wrote:
> Switch to panel timings based on datasheet for the AUO G101EVN01.0
> LVDS panel. Default timings were tested on the panel.
>
> Previous mode-based timings resulted in horizontal display shift.
>
> Signed-off-by: Kevin Baker <kevinb@ventureresearch.com>
> Fixes: 4fb86404a977 ("drm/panel: simple: Add AUO G101EVN010 panel support")
> ---
> drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++------------
> 1 file changed, 13 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index df718c4a86cb..c79dc8581054 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1026,27 +1026,28 @@ static const struct panel_desc auo_g070vvn01 = {
> },
> };
>
> -static const struct drm_display_mode auo_g101evn010_mode = {
> - .clock = 68930,
> - .hdisplay = 1280,
> - .hsync_start = 1280 + 82,
> - .hsync_end = 1280 + 82 + 2,
> - .htotal = 1280 + 82 + 2 + 84,
> - .vdisplay = 800,
> - .vsync_start = 800 + 8,
> - .vsync_end = 800 + 8 + 2,
> - .vtotal = 800 + 8 + 2 + 6,
> +static const struct display_timing auo_g101evn010_timing = {
> + .pixelclock = { 64000000, 68930000, 85000000 },
> + .hactive = { 1280, 1280, 1280 },
> + .hfront_porch = { 8, 64, 256 },
> + .hback_porch = { 8, 64, 256 },
> + .hsync_len = { 40, 168, 767 },
> + .vactive = { 800, 800, 800 },
> + .vfront_porch = { 4, 8, 100 },
> + .vback_porch = { 4, 8, 100 },
> + .vsync_len = { 8, 16, 223 },
> };
>
> static const struct panel_desc auo_g101evn010 = {
> - .modes = &auo_g101evn010_mode,
> - .num_modes = 1,
> + .timings = &auo_g101evn010_timing,
> + .num_timings = 1,
> .bpc = 6,
> .size = {
> .width = 216,
> .height = 135,
> },
> .bus_format = MEDIA_BUS_FMT_RGB666_1X7X3_SPWG,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> };
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010
2025-05-05 17:02 ` [PATCH v2] " Kevin Baker
2025-05-06 7:42 ` Neil Armstrong
@ 2025-05-06 11:59 ` Dmitry Baryshkov
2025-05-06 12:33 ` Neil Armstrong
2025-05-06 12:30 ` Neil Armstrong
2 siblings, 1 reply; 7+ messages in thread
From: Dmitry Baryshkov @ 2025-05-06 11:59 UTC (permalink / raw)
To: Neil Armstrong, Sam Ravnborg, Kevin Baker
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Alex Gonzalez,
Thierry Reding, Rob Herring, dri-devel, linux-kernel
On Mon, 05 May 2025 12:02:56 -0500, Kevin Baker wrote:
> Switch to panel timings based on datasheet for the AUO G101EVN01.0
> LVDS panel. Default timings were tested on the panel.
>
> Previous mode-based timings resulted in horizontal display shift.
>
>
Applied to drm-misc-next, thanks!
[1/1] drm/panel: simple: Update timings for AUO G101EVN010
commit: d5d283d45c85e774b64100137f34e7d55bfbe45e
Best regards,
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010
2025-05-05 17:02 ` [PATCH v2] " Kevin Baker
2025-05-06 7:42 ` Neil Armstrong
2025-05-06 11:59 ` Dmitry Baryshkov
@ 2025-05-06 12:30 ` Neil Armstrong
2 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2025-05-06 12:30 UTC (permalink / raw)
To: Sam Ravnborg, Kevin Baker
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Alex Gonzalez,
Thierry Reding, Rob Herring, dri-devel, linux-kernel
Hi,
On Mon, 05 May 2025 12:02:56 -0500, Kevin Baker wrote:
> Switch to panel timings based on datasheet for the AUO G101EVN01.0
> LVDS panel. Default timings were tested on the panel.
>
> Previous mode-based timings resulted in horizontal display shift.
>
>
Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-fixes)
[1/1] drm/panel: simple: Update timings for AUO G101EVN010
https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/7c6fa1797a725732981f2d77711c867166737719
--
Neil
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] drm/panel: simple: Update timings for AUO G101EVN010
2025-05-06 11:59 ` Dmitry Baryshkov
@ 2025-05-06 12:33 ` Neil Armstrong
0 siblings, 0 replies; 7+ messages in thread
From: Neil Armstrong @ 2025-05-06 12:33 UTC (permalink / raw)
To: Dmitry Baryshkov, Sam Ravnborg, Kevin Baker
Cc: Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Alex Gonzalez,
Thierry Reding, Rob Herring, dri-devel, linux-kernel
On 06/05/2025 13:59, Dmitry Baryshkov wrote:
> On Mon, 05 May 2025 12:02:56 -0500, Kevin Baker wrote:
>> Switch to panel timings based on datasheet for the AUO G101EVN01.0
>> LVDS panel. Default timings were tested on the panel.
>>
>> Previous mode-based timings resulted in horizontal display shift.
>>
>>
>
> Applied to drm-misc-next, thanks!
Hmm, I applied to -fixes how it should be
>
> [1/1] drm/panel: simple: Update timings for AUO G101EVN010
> commit: d5d283d45c85e774b64100137f34e7d55bfbe45e
>
> Best regards,
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2025-05-06 12:33 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-28 21:07 [PATCH] drm/panel: simple: Update timings for AUO G101EVN010 Kevin Baker
2025-05-05 7:53 ` Neil Armstrong
2025-05-05 17:02 ` [PATCH v2] " Kevin Baker
2025-05-06 7:42 ` Neil Armstrong
2025-05-06 11:59 ` Dmitry Baryshkov
2025-05-06 12:33 ` Neil Armstrong
2025-05-06 12:30 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®