From: Ian Molton <spyro2@gmail.com>
To: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Problematic culture around Signed-off-by
Date: Fri, 21 Jul 2017 12:40:02 +0100 [thread overview]
Message-ID: <d97fdda3-5856-531d-0ee5-ac8f2cc844e6@gmail.com> (raw)
Hi folks,
I've been away from kernel development for a bit, but I've returned and
I'm troubled by what seems to be an entrenched and widespread (IMO)
misuse of the "Signed-off-by:" in commits.
I've now either been asked to sign off RFC quality patches "because its
quicker" on more than one occasion in the last week or so, and I've seen
others signing off code which clearly has no hope of going anywhere near
the kernel. (eg. // commented out lines)
I was of the impression that Signed-off-by: was intended to be used on
essentially *finished* commits, indicating both readiness for inclusion
upstream and ones ownership of the copyright.
Even if the intent is *purely* a copyright isue, Signing off
*everything* surely makes it far too easy for people to get junk into
the kernel.
I've actually been deliberately NOT signing off my code because I *DONT*
want it surreptitiously applied with my name on it unless its 100% spot on.
WTH is going on? How can we fix this?
Is Signed-off-by: a lost cause for code quality?
Do we need to add a
Ready-for-mainline: {yes,no} field as well?
Have I just missed something? Maybe I'm just in a minority here? Whats
going on?
-Ian
next reply other threads:[~2017-07-21 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 11:40 Ian Molton [this message]
2017-07-30 18:52 ` Pavel Machek
2017-07-31 13:34 ` Adam Borowski
2017-07-31 13:44 ` Kirill A. Shutemov
2017-07-31 13:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d97fdda3-5856-531d-0ee5-ac8f2cc844e6@gmail.com \
--to=spyro2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome