* [PATCH] cpufreq: brcmstb-avs: Fully open-code compatible for grepping
@ 2025-06-13 7:16 Krzysztof Kozlowski
2025-06-13 18:44 ` Florian Fainelli
2025-06-19 7:06 ` Viresh Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2025-06-13 7:16 UTC (permalink / raw)
To: Markus Mayer, Broadcom internal kernel review list,
Rafael J. Wysocki, Viresh Kumar, Florian Fainelli, linux-pm,
linux-arm-kernel, linux-kernel
Cc: Krzysztof Kozlowski
It is very useful to find driver implementing compatibles with `git grep
compatible`, so driver should not use defines for that string, even if
this means string will be effectively duplicated.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/cpufreq/brcmstb-avs-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/brcmstb-avs-cpufreq.c b/drivers/cpufreq/brcmstb-avs-cpufreq.c
index 7b841a086acc..5940d262374f 100644
--- a/drivers/cpufreq/brcmstb-avs-cpufreq.c
+++ b/drivers/cpufreq/brcmstb-avs-cpufreq.c
@@ -765,7 +765,7 @@ static void brcm_avs_cpufreq_remove(struct platform_device *pdev)
}
static const struct of_device_id brcm_avs_cpufreq_match[] = {
- { .compatible = BRCM_AVS_CPU_DATA },
+ { .compatible = "brcm,avs-cpu-data-mem" },
{ }
};
MODULE_DEVICE_TABLE(of, brcm_avs_cpufreq_match);
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: brcmstb-avs: Fully open-code compatible for grepping
2025-06-13 7:16 [PATCH] cpufreq: brcmstb-avs: Fully open-code compatible for grepping Krzysztof Kozlowski
@ 2025-06-13 18:44 ` Florian Fainelli
2025-06-19 7:06 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2025-06-13 18:44 UTC (permalink / raw)
To: Krzysztof Kozlowski, Markus Mayer,
Broadcom internal kernel review list, Rafael J. Wysocki,
Viresh Kumar, linux-pm, linux-arm-kernel, linux-kernel
On 6/13/25 00:16, Krzysztof Kozlowski wrote:
> It is very useful to find driver implementing compatibles with `git grep
> compatible`, so driver should not use defines for that string, even if
> this means string will be effectively duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: brcmstb-avs: Fully open-code compatible for grepping
2025-06-13 7:16 [PATCH] cpufreq: brcmstb-avs: Fully open-code compatible for grepping Krzysztof Kozlowski
2025-06-13 18:44 ` Florian Fainelli
@ 2025-06-19 7:06 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2025-06-19 7:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Markus Mayer, Broadcom internal kernel review list,
Rafael J. Wysocki, Florian Fainelli, linux-pm, linux-arm-kernel,
linux-kernel
On 13-06-25, 09:16, Krzysztof Kozlowski wrote:
> It is very useful to find driver implementing compatibles with `git grep
> compatible`, so driver should not use defines for that string, even if
> this means string will be effectively duplicated.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/cpufreq/brcmstb-avs-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-19 7:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-13 7:16 [PATCH] cpufreq: brcmstb-avs: Fully open-code compatible for grepping Krzysztof Kozlowski
2025-06-13 18:44 ` Florian Fainelli
2025-06-19 7:06 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®