mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: <krzysztof.kozlowski@linaro.org>, <djakov@kernel.org>,
	<robh@kernel.org>, <conor+dt@kernel.org>, <andersson@kernel.org>,
	<konrad.dybcio@linaro.org>, <linux-arm-msm@vger.kernel.org>,
	<linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <kernel@quicinc.com>
Subject: Re: [RFC PATCH 0/2] arm64: qcom: Add BWMON support for SA8775p
Date: Mon, 17 Jun 2024 18:42:42 +0800	[thread overview]
Message-ID: <d997f42d-0616-4180-ae36-9d2ebd60d15f@quicinc.com> (raw)
In-Reply-To: <yb3ni6o22zdm2lqodj7utdb2dlg3jkbwzutxhmljxle3syoe5y@op2prslmri4y>



On 6/17/2024 5:43 PM, Dmitry Baryshkov wrote:
> On Mon, Jun 17, 2024 at 05:29:38PM GMT, Tengfei Fan wrote:
>> Add CPU and LLCC BWMON nodes and their corresponding OPP tables for
>> SA8775p SoC.
> 
> This series is marked as RFC, Request For Comments. What kind of
> comments are expected for the series?
> 

I found that the BWMON patch for x1e80100[1] is currently under review. 
There are upstream comments suggesting that we reference the same shared 
OPP table from all the BWMONs that share the same OPP table. However, 
there will be some DTBS CHECK warnings[2] if we do reference the same 
shared OPP table.

Therefore, I pushed this patch series to collect some comments on 
whether we can have separate OPP tables for each BWMON, as the OPP table 
of "pmu@90b5400" and "pmu@90b6400" in this patch series.

[1] 
https://lore.kernel.org/lkml/4ef1d9a9-6a0e-4324-b6d5-2ae225855b03@linaro.org/

[2]
arch/arm64/boot/dts/qcom/sa8775p-ride.dtb: pmu@90b5400: 'opp-table' is a 
required property from schema $id:
http://devicetree.org/schemas/interconnect/qcom,msm8998-bwmon.yaml#

>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>
>> This patch series depends on patch series:
>> "[PATCH 2/4] soc: qcom: icc-bwmon: Allow for interrupts to be shared across instances"
>> https://lore.kernel.org/lkml/20240604011157.2358019-3-quic_sibis@quicinc.com/
>>
>> Tengfei Fan (2):
>>    dt-bindings: interconnect: qcom-bwmon: Document SA8775p bwmon
>>      compatibles
>>    arm64: dts: qcom: sa8775p: Add CPU and LLCC BWMON
>>
>>   .../interconnect/qcom,msm8998-bwmon.yaml      |   2 +
>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi         | 115 ++++++++++++++++++
>>   2 files changed, 117 insertions(+)
>>
>>
>> base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0
>> -- 
>> 2.25.1
>>
> 

-- 
Thx and BRs,
Tengfei Fan

  reply	other threads:[~2024-06-17 10:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-17  9:29 Tengfei Fan
2024-06-17  9:29 ` [RFC PATCH 1/2] dt-bindings: interconnect: qcom-bwmon: Document SA8775p bwmon compatibles Tengfei Fan
2024-06-17  9:29 ` [RFC PATCH 2/2] arm64: dts: qcom: sa8775p: Add CPU and LLCC BWMON Tengfei Fan
2024-06-17  9:43 ` [RFC PATCH 0/2] arm64: qcom: Add BWMON support for SA8775p Dmitry Baryshkov
2024-06-17 10:42   ` Tengfei Fan [this message]
2024-06-17 11:00     ` Dmitry Baryshkov
2024-06-18  0:12       ` Tengfei Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d997f42d-0616-4180-ae36-9d2ebd60d15f@quicinc.com \
    --to=quic_tengfan@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djakov@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=kernel@quicinc.com \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®