From: David Heidelberg <david@ixit.cz>
To: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Bryan O'Donoghue <bod@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
Petr Hodina <phodina@protonmail.com>,
"Dr. Git" <drgitx@gmail.com>, Cory Keitz <ckeitz@amazon.com>,
Loic Poulain <loic.poulain@oss.qualcomm.com>
Cc: Frank Li <Frank.Li@nxp.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Kieran Bingham <kbingham@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH v7 7/8] media: qcom: camss: Account for C-PHY when calculating link frequency
Date: Wed, 10 Jun 2026 19:44:28 +0200 [thread overview]
Message-ID: <d99ada08-ab7e-42c3-9e6b-174a4631dc4a@ixit.cz> (raw)
In-Reply-To: <b4599747-7eaa-4ccb-8144-fabfa4c96593@oss.qualcomm.com>
On 10/06/2026 10:23, Wenmeng Liu wrote:
>
>
> On 6/5/2026 9:14 PM, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> Ensure that the link frequency divider correctly accounts for C-PHY
>> operation. The divider differs between D-PHY and C-PHY, as described
>> in the MIPI CSI-2 specification.
>>
>> For more details, see:
>> https://docs.kernel.org/driver-api/media/tx-rx.html#pixel-rate
>>
>> Suggested-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>> Acked-by: Cory Keitz <ckeitz@amazon.com>
>> Tested-by: Cory Keitz <ckeitz@amazon.com>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>> Link: https://docs.kernel.org/driver-api/media/tx-rx.html#pixel-rate
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> drivers/media/platform/qcom/camss/camss-csid.c | 7 +++++--
>> drivers/media/platform/qcom/camss/camss-csiphy.c | 6 ++----
>> drivers/media/platform/qcom/camss/camss.c | 18 +++++++++++++++---
>> drivers/media/platform/qcom/camss/camss.h | 2 +-
>> 4 files changed, 23 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/
>> platform/qcom/camss/camss-csid.c
>> index bcc34ac9dd212..7415e811082da 100644
>> --- a/drivers/media/platform/qcom/camss/camss-csid.c
>> +++ b/drivers/media/platform/qcom/camss/camss-csid.c
>> @@ -534,25 +534,28 @@ const struct csid_format_info *csid_get_fmt_entry(const
>> struct csid_format_info
>> /*
>> * csid_set_clock_rates - Calculate and set clock rates on CSID module
>> * @csiphy: CSID device
>> */
>> static int csid_set_clock_rates(struct csid_device *csid)
>> {
>> struct device *dev = csid->camss->dev;
>> + struct csiphy_device *csiphy = &csid->camss->csiphy[csid->phy.csiphy_id];
>
> The PHY indices are not necessarily contiguous on some platforms, such as Hamoa
> or Purwa.
>
> For example, on Hamoa, we have csiphy0, csiphy1, csiphy2, and csiphy4. Using
> csiphy->id directly would lead to an array out-of-bounds access.
>
Nice catch, thanks. I thought I'll make it cleaner, but I guess this chance
could be pain point. Reverted to passing (number of) `lanes` and just added cphy
bool instead of passing whole struct.
David
> Thanks,
> Wenmeng
>> + struct csiphy_lanes_cfg *lane_cfg = &csiphy->cfg.csi2->lane_cfg;
>> const struct csid_format_info *fmt;
>> +
>> s64 link_freq;
>> int i, j;
>> int ret;
>
--
David Heidelberg
next prev parent reply other threads:[~2026-06-10 17:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-05 13:14 [PATCH v7 0/8] media: camss: Add support for C-PHY configuration on Qualcomm platforms David Heidelberg via B4 Relay
2026-06-05 13:14 ` [PATCH v7 1/8] media: qcom: camss: csiphy: Introduce PHY configuration David Heidelberg via B4 Relay
2026-06-05 13:14 ` [PATCH v7 2/8] media: qcom: camss: csiphy-3ph: Use odd bits for configuring C-PHY lanes David Heidelberg via B4 Relay
2026-06-08 18:16 ` Frank Li
2026-06-08 19:32 ` David Heidelberg
2026-06-09 9:59 ` Nihal Kumar Gupta
2026-06-10 8:18 ` Wenmeng Liu
2026-06-05 13:14 ` [PATCH v7 3/8] media: qcom: camss: Prepare CSID for C-PHY support David Heidelberg via B4 Relay
2026-06-08 18:18 ` Frank Li
2026-06-05 13:14 ` [PATCH v7 4/8] media: qcom: camss: Initialize lanes after lane configuration is available David Heidelberg via B4 Relay
2026-06-05 13:14 ` [PATCH v7 5/8] media: qcom: camss: csiphy-3ph: Add Gen2 v1.1 MIPI CSI-2 C-PHY init David Heidelberg via B4 Relay
2026-06-08 9:00 ` Bryan O'Donoghue
2026-06-08 10:37 ` David Heidelberg
2026-06-05 13:14 ` [PATCH v7 6/8] media: qcom: camss: csiphy-3ph: Update " David Heidelberg via B4 Relay
2026-06-05 13:14 ` [PATCH v7 7/8] media: qcom: camss: Account for C-PHY when calculating link frequency David Heidelberg via B4 Relay
2026-06-10 8:23 ` Wenmeng Liu
2026-06-10 17:44 ` David Heidelberg [this message]
2026-06-05 13:14 ` [PATCH v7 8/8] media: qcom: camss: Enable C-PHY where available David Heidelberg via B4 Relay
2026-06-08 8:56 ` [PATCH v7 0/8] media: camss: Add support for C-PHY configuration on Qualcomm platforms Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d99ada08-ab7e-42c3-9e6b-174a4631dc4a@ixit.cz \
--to=david@ixit.cz \
--cc=Frank.Li@nxp.com \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=ckeitz@amazon.com \
--cc=drgitx@gmail.com \
--cc=kbingham@kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=luca.weiss@fairphone.com \
--cc=mchehab@kernel.org \
--cc=phodina@protonmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=wenmeng.liu@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®