mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <gaoxiang25@huawei.com>
To: Sheng Yong <shengyong1@huawei.com>
Cc: <yuchao0@huawei.com>, <gregkh@linuxfoundation.org>,
	<linux-erofs@lists.ozlabs.org>, <devel@driverdev.osuosl.org>,
	<linux-kernel@vger.kernel.org>, <chao@kernel.org>,
	Miao Xie <miaoxie@huawei.com>,
	"fangwei (I)" <fangwei1@huawei.com>
Subject: Re: [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array
Date: Thu, 14 Feb 2019 15:10:04 +0800	[thread overview]
Message-ID: <d9aefb6b-e3a9-29c4-c230-391aeec19d97@huawei.com> (raw)
In-Reply-To: <20190214064636.30039-1-shengyong1@huawei.com>



On 2019/2/14 14:46, Sheng Yong wrote:
> If it fails to read a shared xattr page, the inode's shared xattr array
> is not freed. The next time the inode's xattr is accessed, the previously
> allocated array is leaked.
> 
> Signed-off-by: Sheng Yong <shengyong1@huawei.com>

LGTM,

Fixes: b17500a0fdba ("staging: erofs: introduce xattr & acl support")
Cc: <stable@vger.kernel.org> # 4.19+
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>

[and there is also another race condition in it, but different root cause.
let me fix it later independently...]

Thanks,
Gao Xiang

  reply	other threads:[~2019-02-14  7:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-14  6:46 Sheng Yong
2019-02-14  7:10 ` Gao Xiang [this message]
2019-02-15  2:13   ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9aefb6b-e3a9-29c4-c230-391aeec19d97@huawei.com \
    --to=gaoxiang25@huawei.com \
    --cc=chao@kernel.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=fangwei1@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=shengyong1@huawei.com \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®