* [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array
@ 2019-02-14 6:46 Sheng Yong
2019-02-14 7:10 ` Gao Xiang
0 siblings, 1 reply; 3+ messages in thread
From: Sheng Yong @ 2019-02-14 6:46 UTC (permalink / raw)
To: gaoxiang25, yuchao0, gregkh; +Cc: linux-erofs, devel, linux-kernel, chao
If it fails to read a shared xattr page, the inode's shared xattr array
is not freed. The next time the inode's xattr is accessed, the previously
allocated array is leaked.
Signed-off-by: Sheng Yong <shengyong1@huawei.com>
---
v2: * s/node/inode in commit message
* add prefix `staging:' to the subject
---
drivers/staging/erofs/xattr.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/erofs/xattr.c b/drivers/staging/erofs/xattr.c
index 80dca6a4adbe..e3f8b904a680 100644
--- a/drivers/staging/erofs/xattr.c
+++ b/drivers/staging/erofs/xattr.c
@@ -92,8 +92,11 @@ static int init_inode_xattrs(struct inode *inode)
it.page = erofs_get_meta_page(sb,
++it.blkaddr, S_ISDIR(inode->i_mode));
- if (IS_ERR(it.page))
+ if (IS_ERR(it.page)) {
+ kfree(vi->xattr_shared_xattrs);
+ vi->xattr_shared_xattrs = NULL;
return PTR_ERR(it.page);
+ }
it.kaddr = kmap_atomic(it.page);
atomic_map = true;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array
2019-02-14 6:46 [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array Sheng Yong
@ 2019-02-14 7:10 ` Gao Xiang
2019-02-15 2:13 ` Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Gao Xiang @ 2019-02-14 7:10 UTC (permalink / raw)
To: Sheng Yong
Cc: yuchao0, gregkh, linux-erofs, devel, linux-kernel, chao,
Miao Xie, fangwei (I)
On 2019/2/14 14:46, Sheng Yong wrote:
> If it fails to read a shared xattr page, the inode's shared xattr array
> is not freed. The next time the inode's xattr is accessed, the previously
> allocated array is leaked.
>
> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
LGTM,
Fixes: b17500a0fdba ("staging: erofs: introduce xattr & acl support")
Cc: <stable@vger.kernel.org> # 4.19+
Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
[and there is also another race condition in it, but different root cause.
let me fix it later independently...]
Thanks,
Gao Xiang
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array
2019-02-14 7:10 ` Gao Xiang
@ 2019-02-15 2:13 ` Chao Yu
0 siblings, 0 replies; 3+ messages in thread
From: Chao Yu @ 2019-02-15 2:13 UTC (permalink / raw)
To: Gao Xiang, Sheng Yong
Cc: gregkh, linux-erofs, devel, linux-kernel, chao, Miao Xie, fangwei (I)
On 2019/2/14 15:10, Gao Xiang wrote:
>
>
> On 2019/2/14 14:46, Sheng Yong wrote:
>> If it fails to read a shared xattr page, the inode's shared xattr array
>> is not freed. The next time the inode's xattr is accessed, the previously
>> allocated array is leaked.
Nice catch!
>>
>> Signed-off-by: Sheng Yong <shengyong1@huawei.com>
>
> LGTM,
>
> Fixes: b17500a0fdba ("staging: erofs: introduce xattr & acl support")
> Cc: <stable@vger.kernel.org> # 4.19+
> Reviewed-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
>
> [and there is also another race condition in it, but different root cause.
> let me fix it later independently...]
>
> Thanks,
> Gao Xiang
>
> .
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-15 2:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 6:46 [PATCH v2] staging: erofs: fix memleak of inode's shared xattr array Sheng Yong
2019-02-14 7:10 ` Gao Xiang
2019-02-15 2:13 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®