* [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h
@ 2023-07-09 10:05 Sui Jingfeng
2023-07-09 14:31 ` Thomas Zimmermann
2023-07-10 5:20 ` Michael Kelley (LINUX)
0 siblings, 2 replies; 4+ messages in thread
From: Sui Jingfeng @ 2023-07-09 10:05 UTC (permalink / raw)
To: Deepak Rawat, David Airlie, Daniel Vetter, Michael Kelley,
Thomas Zimmermann, Javier Martinez Canillas, Arnd Bergmann
Cc: linux-hyperv, dri-devel, linux-kernel, kernel test robot
drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
>> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use in this function)
1033 | base = screen_info.lfb_base;
| ^~~~~~~~~~~
drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported only once for each function it appears in
--
drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared (first use in this function)
75 | drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
| ^~~~~~~~~~~
drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is reported only once for each function it appears in
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@intel.com/
Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
index a7d2c92d6c6a..8026118c6e03 100644
--- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
+++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
@@ -7,6 +7,7 @@
#include <linux/hyperv.h>
#include <linux/module.h>
#include <linux/pci.h>
+#include <linux/screen_info.h>
#include <drm/drm_aperture.h>
#include <drm/drm_atomic_helper.h>
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h
2023-07-09 10:05 [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h Sui Jingfeng
@ 2023-07-09 14:31 ` Thomas Zimmermann
2023-07-10 5:20 ` Michael Kelley (LINUX)
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2023-07-09 14:31 UTC (permalink / raw)
To: Sui Jingfeng, Deepak Rawat, David Airlie, Daniel Vetter,
Michael Kelley, Javier Martinez Canillas, Arnd Bergmann
Cc: linux-hyperv, linux-kernel, dri-devel, kernel test robot
[-- Attachment #1.1: Type: text/plain, Size: 2239 bytes --]
Hi
Am 09.07.23 um 12:05 schrieb Sui Jingfeng:
> drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
>>> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use in this function)
> 1033 | base = screen_info.lfb_base;
> | ^~~~~~~~~~~
> drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported only once for each function it appears in
> --
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
>>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared (first use in this function)
> 75 | drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
> | ^~~~~~~~~~~
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is reported only once for each function it appears in
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@intel.com/
> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Thanks for the patch.
Best regards
Thomas
> ---
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> index a7d2c92d6c6a..8026118c6e03 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> @@ -7,6 +7,7 @@
> #include <linux/hyperv.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> +#include <linux/screen_info.h>
>
> #include <drm/drm_aperture.h>
> #include <drm/drm_atomic_helper.h>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h
2023-07-09 10:05 [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h Sui Jingfeng
2023-07-09 14:31 ` Thomas Zimmermann
@ 2023-07-10 5:20 ` Michael Kelley (LINUX)
2023-07-10 6:34 ` suijingfeng
1 sibling, 1 reply; 4+ messages in thread
From: Michael Kelley (LINUX) @ 2023-07-10 5:20 UTC (permalink / raw)
To: Sui Jingfeng, Deepak Rawat, David Airlie, Daniel Vetter,
Thomas Zimmermann, Javier Martinez Canillas, Arnd Bergmann
Cc: linux-hyperv, dri-devel, linux-kernel, kernel test robot
From: Sui Jingfeng <suijingfeng@loongson.cn> Sent: Sunday, July 9, 2023 3:05 AM
>
> drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
> >> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use
> in this function)
> 1033 | base = screen_info.lfb_base;
> | ^~~~~~~~~~~
> drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported
> only once for each function it appears in
> --
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
> >> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared
> (first use in this function)
> 75 | drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
> | ^~~~~~~~~~~
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is
> reported only once for each function it appears in
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@intel.com/
> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
> drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> index a7d2c92d6c6a..8026118c6e03 100644
> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
> @@ -7,6 +7,7 @@
> #include <linux/hyperv.h>
> #include <linux/module.h>
> #include <linux/pci.h>
> +#include <linux/screen_info.h>
>
> #include <drm/drm_aperture.h>
> #include <drm/drm_atomic_helper.h>
> --
> 2.25.1
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h
2023-07-10 5:20 ` Michael Kelley (LINUX)
@ 2023-07-10 6:34 ` suijingfeng
0 siblings, 0 replies; 4+ messages in thread
From: suijingfeng @ 2023-07-10 6:34 UTC (permalink / raw)
To: Michael Kelley (LINUX),
Deepak Rawat, David Airlie, Daniel Vetter, Thomas Zimmermann,
Javier Martinez Canillas, Arnd Bergmann
Cc: linux-hyperv, dri-devel, linux-kernel, kernel test robot
OK, thanks a lot,
done!
On 2023/7/10 13:20, Michael Kelley (LINUX) wrote:
> From: Sui Jingfeng <suijingfeng@loongson.cn> Sent: Sunday, July 9, 2023 3:05 AM
>> drivers/video/fbdev/hyperv_fb.c: In function 'hvfb_getmem':
>>>> drivers/video/fbdev/hyperv_fb.c:1033:24: error: 'screen_info' undeclared (first use
>> in this function)
>> 1033 | base = screen_info.lfb_base;
>> | ^~~~~~~~~~~
>> drivers/video/fbdev/hyperv_fb.c:1033:24: note: each undeclared identifier is reported
>> only once for each function it appears in
>> --
>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c: In function 'hyperv_setup_vram':
>>>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: error: 'screen_info' undeclared
>> (first use in this function)
>> 75 | drm_aperture_remove_conflicting_framebuffers(screen_info.lfb_base,
>> | ^~~~~~~~~~~
>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c:75:54: note: each undeclared identifier is
>> reported only once for each function it appears in
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202307090823.nxnT8Kk5-lkp@intel.com/
>> Fixes: 81d2393485f0 ("fbdev/hyperv-fb: Do not set struct fb_info.apertures")
>> Fixes: 8b0d13545b09 ("efi: Do not include <linux/screen_info.h> from EFI header")
>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
>> ---
>> drivers/gpu/drm/hyperv/hyperv_drm_drv.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> index a7d2c92d6c6a..8026118c6e03 100644
>> --- a/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> +++ b/drivers/gpu/drm/hyperv/hyperv_drm_drv.c
>> @@ -7,6 +7,7 @@
>> #include <linux/hyperv.h>
>> #include <linux/module.h>
>> #include <linux/pci.h>
>> +#include <linux/screen_info.h>
>>
>> #include <drm/drm_aperture.h>
>> #include <drm/drm_atomic_helper.h>
>> --
>> 2.25.1
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-10 6:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-09 10:05 [PATCH] drm/hyperv: Fix a compilation issue because of not including screen_info.h Sui Jingfeng
2023-07-09 14:31 ` Thomas Zimmermann
2023-07-10 5:20 ` Michael Kelley (LINUX)
2023-07-10 6:34 ` suijingfeng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®