* [PATCH] KVM: SVM: Fix offset computation bug in __sev_dbg_decrypt().
@ 2020-11-10 22:42 Ashish Kalra
2020-11-16 18:59 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: Ashish Kalra @ 2020-11-10 22:42 UTC (permalink / raw)
To: pbonzini
Cc: tglx, mingo, hpa, joro, bp, thomas.lendacky, Brijesh.Singh, x86,
kvm, linux-kernel, ssg.sos.patches
From: Ashish Kalra <ashish.kalra@amd.com>
Fix offset computation in __sev_dbg_decrypt() to include the
source paddr before it is rounded down to be aligned to 16 bytes
as required by SEV API. This fixes incorrect guest memory dumps
observed when using qemu monitor.
Signed-off-by: Ashish Kalra <ashish.kalra@amd.com>
---
arch/x86/kvm/svm/sev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
index c0b14106258a..566f4d18185b 100644
--- a/arch/x86/kvm/svm/sev.c
+++ b/arch/x86/kvm/svm/sev.c
@@ -642,8 +642,8 @@ static int __sev_dbg_decrypt(struct kvm *kvm, unsigned long src_paddr,
* Its safe to read more than we are asked, caller should ensure that
* destination has enough space.
*/
- src_paddr = round_down(src_paddr, 16);
offset = src_paddr & 15;
+ src_paddr = round_down(src_paddr, 16);
sz = round_up(sz + offset, 16);
return __sev_issue_dbg_cmd(kvm, src_paddr, dst_paddr, sz, err, false);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: SVM: Fix offset computation bug in __sev_dbg_decrypt().
2020-11-10 22:42 [PATCH] KVM: SVM: Fix offset computation bug in __sev_dbg_decrypt() Ashish Kalra
@ 2020-11-16 18:59 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2020-11-16 18:59 UTC (permalink / raw)
To: Ashish Kalra
Cc: tglx, mingo, hpa, joro, bp, thomas.lendacky, Brijesh.Singh, x86,
kvm, linux-kernel, ssg.sos.patches
On 10/11/20 23:42, Ashish Kalra wrote:
> From: Ashish Kalra <ashish.kalra@amd.com>
>
> Fix offset computation in __sev_dbg_decrypt() to include the
> source paddr before it is rounded down to be aligned to 16 bytes
> as required by SEV API. This fixes incorrect guest memory dumps
> observed when using qemu monitor.
>
> Signed-off-by: Ashish Kalra <ashish.kalra@amd.com>
> ---
> arch/x86/kvm/svm/sev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index c0b14106258a..566f4d18185b 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -642,8 +642,8 @@ static int __sev_dbg_decrypt(struct kvm *kvm, unsigned long src_paddr,
> * Its safe to read more than we are asked, caller should ensure that
> * destination has enough space.
> */
> - src_paddr = round_down(src_paddr, 16);
> offset = src_paddr & 15;
> + src_paddr = round_down(src_paddr, 16);
> sz = round_up(sz + offset, 16);
>
> return __sev_issue_dbg_cmd(kvm, src_paddr, dst_paddr, sz, err, false);
>
I just missed it. Queued now, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-16 18:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-10 22:42 [PATCH] KVM: SVM: Fix offset computation bug in __sev_dbg_decrypt() Ashish Kalra
2020-11-16 18:59 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®