mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "André Draszik" <andre.draszik@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	 Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Ulf Hansson	 <ulf.hansson@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown	 <broonie@kernel.org>,
	Peter Griffin <peter.griffin@linaro.org>,
	Tudor Ambarus	 <tudor.ambarus@linaro.org>,
	Juan Yescas <jyescas@google.com>,
	Will McVicker <willmcvicker@google.com>,
	kernel-team@android.com,  linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,  linux-pm@vger.kernel.org
Subject: Re: [PATCH v7 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children
Date: Fri, 13 Mar 2026 10:48:55 +0000	[thread overview]
Message-ID: <da0726da3e59d83985650e8281ed945018a356e4.camel@linaro.org> (raw)
In-Reply-To: <20260312151228.GA3136988-robh@kernel.org>

On Thu, 2026-03-12 at 10:12 -0500, Rob Herring wrote:
> On Fri, Mar 06, 2026 at 10:29:55AM +0000, André Draszik wrote:
> 
> >      system-controller@17460000 {
> >          compatible = "google,gs101-pmu";
> >          reg = <0x17460000 0x10000>;
> > +        #address-cells = <1>;
> > +        #size-cells = <1>;
> > +        ranges;
> >  
> >          google,pmu-intr-gen-syscon = <&pmu_intr_gen>;
> > +
> > +        pd_g3d: power-domain@1e00 {
> > +            compatible = "google,gs101-pd";
> > +            reg = <0x1e00 0x80>;
> 
> I'm assuming 0x1e00 is an offset from 0x17460000. That's not what ranges 
> says though. It says both addresses are in the same address space 
> (system-controller@17460000 parent's address space). You need:
> 
> ranges = <0x0 0x17460000 0x10000>;

Thanks Rob! On gs101, the PD driver can not do direct mmio. Instead it
needs to use the regmap that the parent has created and apply the
offset from the PD's reg property (using struct resource::start)
(patch 7).

When using ranges as per your suggestion that doesn't work anymore,
as resource->start isn't the offset anymore but the final physical
address, and using that in combination with the parent's regmap
doesn't give us the right address anymore.

Is there an alternative other than using completely arbitrary indices
like e.g. rockchip is doing?


Cheers,
Andre'

  reply	other threads:[~2026-03-13 10:48 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-06 10:29 [PATCH v7 00/10] pmdomain: samsung: add support for Google GS101 André Draszik
2026-03-06 10:29 ` [PATCH v7 01/10] dt-bindings: soc: google: add google,gs101-dtzpc André Draszik
2026-03-06 14:59   ` Peter Griffin
2026-03-06 10:29 ` [PATCH v7 02/10] dt-bindings: power: samsung: add google,gs101-pd André Draszik
2026-03-06 14:56   ` Peter Griffin
2026-03-06 10:29 ` [PATCH v7 03/10] dt-bindings: soc: samsung: exynos-pmu: move gs101-pmu into separate binding André Draszik
2026-03-06 14:59   ` Peter Griffin
2026-03-06 10:29 ` [PATCH v7 04/10] dt-bindings: soc: google: gs101-pmu: allow power domains as children André Draszik
2026-03-06 15:12   ` Peter Griffin
2026-03-12 15:12   ` Rob Herring
2026-03-13 10:48     ` André Draszik [this message]
2026-03-13 11:43       ` André Draszik
2026-03-13 13:26       ` Rob Herring
2026-03-13 14:15         ` André Draszik
2026-03-06 10:29 ` [PATCH v7 05/10] pmdomain: samsung: convert to using regmap André Draszik
2026-03-06 15:30   ` Peter Griffin
2026-03-06 10:29 ` [PATCH v7 06/10] pmdomain: samsung: don't hard-code offset for registers to 0 and 4 André Draszik
2026-03-06 15:51   ` Peter Griffin
2026-03-06 10:29 ` [PATCH v7 07/10] pmdomain: samsung: add support for google,gs101-pd André Draszik
2026-03-06 15:20   ` Peter Griffin
2026-03-06 10:29 ` [PATCH v7 08/10] pmdomain: samsung: use dev_err() instead of pr_err() André Draszik
2026-03-06 15:21   ` Peter Griffin
2026-03-06 10:30 ` [PATCH v7 09/10] pmdomain: samsung: implement SMC to save / restore TZ config André Draszik
2026-03-06 15:37   ` Peter Griffin
2026-03-06 10:30 ` [PATCH v7 10/10] pmdomain: samsung: implement domain-supply regulator André Draszik
2026-03-06 15:47   ` Peter Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da0726da3e59d83985650e8281ed945018a356e4.camel@linaro.org \
    --to=andre.draszik@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jyescas@google.com \
    --cc=kernel-team@android.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=tudor.ambarus@linaro.org \
    --cc=ulf.hansson@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®