[PATCH v2 0/3] Add MT8365 SMI driver support

[PATCH v2 0/3] Add MT8365 SMI driver support

[Alexandre Mergnat]

This serie add MT8365 SMI common driver support, to be bisectable and
avoid issue with the DTS change. This driver change and the related
change in the DTS should be applied in the right order (driver first).

Here the related DTS change: [1]

Also add the SMI common and LARB bindings for MT8365 support,
I kept the Matthias Brugger reviewed-by from the previous series [3] [4].

Regards,
Alexandre

[1]: https://lore.kernel.org/all/20230207-iommu-support-v2-7-60d5fa00e4e5@baylibre.com/
[2]: https://lore.kernel.org/all/9ad8c606026586b682df5e0ce0c699e21a1e6fb7.camel@mediatek.com/
[3]: https://lore.kernel.org/all/d1dc242d-c381-3307-b939-7bc35c6ce55b@gmail.com/
[4]: https://lore.kernel.org/all/0e863367-5b24-9559-f782-4d3e5dc06961@gmail.com/

Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
---
Changes in v2:
- Add SMI common and LARB bindings for MT8365 support.
  I kept trailers [3] [4]
- Forgot to mention, in the v1, I've addressed the Yong Wu's comment [2]
  by removing "has_gals=true" from the mtk_smi_common_mt8365 structure.
  Then I've put the reviewed-by.
- Link to v1: https://lore.kernel.org/r/20230407-smi-driver-v1-1-036d6d8e8993@baylibre.com

---
Alexandre Mergnat (3):
      memory: mtk-smi: mt8365: Add SMI Support
      dt-bindings: memory-controllers: mediatek,smi-common: add mt8365
      dt-bindings: memory-controllers: mediatek,smi-larb: add mt8365

 .../devicetree/bindings/memory-controllers/mediatek,smi-common.yaml | 2 ++
 .../devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml   | 4 ++++
 drivers/memory/mtk-smi.c                                            | 6 ++++++
 3 files changed, 12 insertions(+)
---
base-commit: ea2dcf9394947d5d8e24cb9d52144923f6645632
change-id: 20230407-smi-driver-782270b6da2e

Best regards,
-- 
Alexandre Mergnat <amergnat@baylibre.com>

[PATCH v2 1/3] memory: mtk-smi: mt8365: Add SMI Support

[Alexandre Mergnat]

Add MT8365 SMI common support.

Reviewed-by: Yong Wu <yong.wu@mediatek.com>
Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
---
 drivers/memory/mtk-smi.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index 5a9754442bc7..6523cb510518 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -713,6 +713,11 @@ static const struct mtk_smi_common_plat mtk_smi_sub_common_mt8195 = {
 	.has_gals = true,
 };
 
+static const struct mtk_smi_common_plat mtk_smi_common_mt8365 = {
+	.type     = MTK_SMI_GEN2,
+	.bus_sel  = F_MMU1_LARB(2) | F_MMU1_LARB(4),
+};
+
 static const struct of_device_id mtk_smi_common_of_ids[] = {
 	{.compatible = "mediatek,mt2701-smi-common", .data = &mtk_smi_common_gen1},
 	{.compatible = "mediatek,mt2712-smi-common", .data = &mtk_smi_common_gen2},
@@ -728,6 +733,7 @@ static const struct of_device_id mtk_smi_common_of_ids[] = {
 	{.compatible = "mediatek,mt8195-smi-common-vdo", .data = &mtk_smi_common_mt8195_vdo},
 	{.compatible = "mediatek,mt8195-smi-common-vpp", .data = &mtk_smi_common_mt8195_vpp},
 	{.compatible = "mediatek,mt8195-smi-sub-common", .data = &mtk_smi_sub_common_mt8195},
+	{.compatible = "mediatek,mt8365-smi-common", .data = &mtk_smi_common_mt8365},
 	{}
 };
 

-- 
2.25.1

Re: [PATCH v2 1/3] memory: mtk-smi: mt8365: Add SMI Support

[AngeloGioacchino Del Regno]

Il 07/04/23 11:13, Alexandre Mergnat ha scritto:
> Add MT8365 SMI common support.
> 
> Reviewed-by: Yong Wu <yong.wu@mediatek.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

[PATCH v2 2/3] dt-bindings: memory-controllers: mediatek,smi-common: add mt8365

[Alexandre Mergnat]

Add binding description for mediatek,mt8365-smi-common

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
---
 .../devicetree/bindings/memory-controllers/mediatek,smi-common.yaml     | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
index a8fda30cccbb..2f36ac23604c 100644
--- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml
@@ -43,6 +43,7 @@ properties:
           - mediatek,mt8195-smi-common-vdo
           - mediatek,mt8195-smi-common-vpp
           - mediatek,mt8195-smi-sub-common
+          - mediatek,mt8365-smi-common
 
       - description: for mt7623
         items:
@@ -133,6 +134,7 @@ allOf:
             - mediatek,mt8192-smi-common
             - mediatek,mt8195-smi-common-vdo
             - mediatek,mt8195-smi-common-vpp
+            - mediatek,mt8365-smi-common
 
     then:
       properties:

-- 
2.25.1

Re: [PATCH v2 2/3] dt-bindings: memory-controllers: mediatek,smi-common: add mt8365

[AngeloGioacchino Del Regno]

Il 07/04/23 11:13, Alexandre Mergnat ha scritto:
> Add binding description for mediatek,mt8365-smi-common
> 
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

...but the bindings commits should come before the driver commits.

[PATCH v2 3/3] dt-bindings: memory-controllers: mediatek,smi-larb: add mt8365

[Alexandre Mergnat]

Add binding description for mediatek,mt8365-smi-larb

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>
---
 .../devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml     | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
index 5f4ac3609887..aee7f6cf1300 100644
--- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml
@@ -34,6 +34,10 @@ properties:
           - const: mediatek,mt7623-smi-larb
           - const: mediatek,mt2701-smi-larb
 
+      - items:
+          - const: mediatek,mt8365-smi-larb
+          - const: mediatek,mt8186-smi-larb
+
   reg:
     maxItems: 1
 

-- 
2.25.1

Re: [PATCH v2 3/3] dt-bindings: memory-controllers: mediatek,smi-larb: add mt8365

[AngeloGioacchino Del Regno]

Il 07/04/23 11:13, Alexandre Mergnat ha scritto:
> Add binding description for mediatek,mt8365-smi-larb
> 
> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com>

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

...but the bindings commits should come before the driver commits.

Re: [PATCH v2 0/3] Add MT8365 SMI driver support

[Krzysztof Kozlowski]

On Fri, 07 Apr 2023 11:13:50 +0200, Alexandre Mergnat wrote:
> This serie add MT8365 SMI common driver support, to be bisectable and
> avoid issue with the DTS change. This driver change and the related
> change in the DTS should be applied in the right order (driver first).
> 
> Here the related DTS change: [1]
> 
> Also add the SMI common and LARB bindings for MT8365 support,
> I kept the Matthias Brugger reviewed-by from the previous series [3] [4].
> 
> [...]

Applied, thanks! It's late, so it might miss current cycle.

With corrected order of patches (I don't know why you decided to reorder
bindings with driver. Bindings should be before its usage).


[1/3] memory: mtk-smi: mt8365: Add SMI Support
      https://git.kernel.org/krzk/linux-mem-ctrl/c/3ec0e1ea4770e40575bfb2bb4e9ebbbaa3c80d3f
[2/3] dt-bindings: memory-controllers: mediatek,smi-common: add mt8365
      https://git.kernel.org/krzk/linux-mem-ctrl/c/67025255ee8b1ec496b01f74e8c298d211bc7a82
[3/3] dt-bindings: memory-controllers: mediatek,smi-larb: add mt8365
      https://git.kernel.org/krzk/linux-mem-ctrl/c/4ad9a801a3597ccfd406c911638aca2c61e57bdf

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>