mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Chris Lu (陸稚泓)" <Chris.Lu@mediatek.com>
To: "luiz.dentz@gmail.com" <luiz.dentz@gmail.com>
Cc: "Hao Qin (秦浩)" <Hao.Qin@mediatek.com>,
	"Will-CY Lee (李政穎)" <Will-CY.Lee@mediatek.com>,
	"Wenlong Tian (田文龙)" <ot_wenlong.tian@mediatek.com>,
	"marcel@holtmann.org" <marcel@holtmann.org>,
	"SS Wu (巫憲欣)" <ss.wu@mediatek.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"johan.hedberg@gmail.com" <johan.hedberg@gmail.com>,
	"Sean Wang" <Sean.Wang@mediatek.com>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	"linux-mediatek@lists.infradead.org"
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v3 RESEND 0/3] Bluetooth: btmtk: fix ISO data reception
Date: Thu, 22 Oct 2026 01:25:03 +0000	[thread overview]
Message-ID: <da3104c527964d3f29f4bfee9e332364994d623b.camel@mediatek.com> (raw)
In-Reply-To: <CABBYNZKqAa+3V1k3U-NBodfAhYRV3ZqX4V7bp5NFrXY0ndgL7Q@mail.gmail.com>

Hi Luiz,

Thanks for the reminder, I've noticed the results of Sashiko's review.

On Wed, 2026-10-21 at 10:23 -0400, Luiz Augusto von Dentz wrote:
> Hi Chris,
> 
> On Wed, Oct 21, 2026 at 4:43 AM Chris Lu <chris.lu@mediatek.com>
> wrote:
> > 
> > Resend due to rebase: the base this series was previously posted
> > against
> > no longer exists in bluetooth-next's history, which is why it
> > failed to
> > apply. Rebased onto current bluetooth-next; no content changes from
> > v3.
> > 
> > Two fixes for btmtk_recv_isopkt(), found while debugging LE Audio
> > on
> > MT7925, plus an update to the ISO data transmission setting. The
> > function
> > is shared by every MediaTek USB controller that supports ISO data,
> > so none
> > of this is specific to that part.
> > 
> > Patch 1 drops the zero padding that the ISO interrupt IN endpoint
> > appends
> > to each transfer instead of parsing it as ISO packets.
> > 
> > Patch 2 bounds Data_Total_Length by hdev->iso_mtu.
> > 
> > Patch 3 updates the mt79xx ISO data transmission setting.
> > 
> > The three hunks do not overlap, so any prefix of the series applies
> > on its
> > own.
> > 
> > Changes in v3 RESEND:
> > - Resend due to rebase. No content changes.
> > 
> > Changes in v3:
> > - Patch 1: instead of dropping a packet solely because
> > Data_Total_Length
> >   is zero, also confirm that the rest of the transfer is zero-
> > filled
> >   before treating it as padding.
> > - Patch 2, 3: unchanged.
> > 
> > Changes in v2:
> > - Patch 2 reworked and retitled.
> > - Patch 3 added.
> > 
> > Based on bluetooth-next.
> > 
> > Chris Lu (3):
> >   Bluetooth: btmtk: drop zero-length ISO packets from endpoint
> > padding
> >   Bluetooth: btmtk: bound the ISO payload length by the
> > controller's MTU
> >   Bluetooth: btmtk: derive the firmware ISO setting from
> >     MTK_ISO_THRESHOLD
> > 
> >  drivers/bluetooth/btmtk.c | 44 ++++++++++++++++++++++++++++++++++-
> > ----
> >  1 file changed, 39 insertions(+), 5 deletions(-)
> > 
> > --
> > 2.45.2
> > 
> 
> Sashiko is still flagging a problem:
> 
> https://urldefense.com/v3/__https://sashiko.dev/*/patchset/20261021084337.1515468-1-chris.lu*40mediatek.com__;IyU!!CTRNKA9wMg0ARbw!heJ4Q7JNUGP7kU0I1b-VYacWXQtYzXNUNhsuWVeqBSzOyMw8rIeqJ_WJV187h0noHUi3xzGLwHGlcvWmCIA$
>  
> 

I'll send the next version after confirming my fix is effective and all
basic functions work normally.

Thanks,
Chris Lu


      reply	other threads:[~2026-10-22  1:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-21  8:43 Chris Lu
2026-10-21  8:43 ` [PATCH v3 RESEND 1/3] Bluetooth: btmtk: drop zero-length ISO packets from endpoint padding Chris Lu
2026-10-21  8:43 ` [PATCH v3 RESEND 2/3] Bluetooth: btmtk: bound the ISO payload length by the controller's MTU Chris Lu
2026-10-21  8:43 ` [PATCH v3 RESEND 3/3] Bluetooth: btmtk: derive the firmware ISO setting from MTK_ISO_THRESHOLD Chris Lu
2026-10-21 14:23 ` [PATCH v3 RESEND 0/3] Bluetooth: btmtk: fix ISO data reception Luiz Augusto von Dentz
2026-10-22  1:25   ` Chris Lu (陸稚泓) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da3104c527964d3f29f4bfee9e332364994d623b.camel@mediatek.com \
    --to=chris.lu@mediatek.com \
    --cc=Hao.Qin@mediatek.com \
    --cc=Sean.Wang@mediatek.com \
    --cc=Will-CY.Lee@mediatek.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    --cc=ot_wenlong.tian@mediatek.com \
    --cc=ss.wu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®