From: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Bryan O'Donoghue <bod@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/8] media: qcom: iris: merge hfi_response_ops and hfi_command_ops
Date: Wed, 11 Mar 2026 17:48:53 +0530 [thread overview]
Message-ID: <da36d6b6-9331-4711-9c26-3f17e062219c@oss.qualcomm.com> (raw)
In-Reply-To: <20260311-iris-platform-data-v3-5-f02258c4d4ed@oss.qualcomm.com>
On 3/11/2026 10:35 AM, Dmitry Baryshkov wrote:
> There is little point in having two different structures for HFI-related
> core ops. Merge both of them into the new iris_hfi_ops structure.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> drivers/media/platform/qcom/iris/iris_core.h | 3 +--
> drivers/media/platform/qcom/iris/iris_hfi_common.c | 6 +++---
> drivers/media/platform/qcom/iris/iris_hfi_common.h | 8 +++-----
> drivers/media/platform/qcom/iris/iris_hfi_gen1.h | 4 ++--
> drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 8 +++++---
> drivers/media/platform/qcom/iris/iris_hfi_gen1_response.c | 11 +----------
> drivers/media/platform/qcom/iris/iris_hfi_gen2.h | 4 ++--
> drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 8 +++++---
> drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c | 11 +----------
> drivers/media/platform/qcom/iris/iris_platform_common.h | 3 +--
> drivers/media/platform/qcom/iris/iris_platform_gen1.c | 6 ++----
> drivers/media/platform/qcom/iris/iris_platform_gen2.c | 12 ++++--------
> drivers/media/platform/qcom/iris/iris_probe.c | 3 +--
> drivers/media/platform/qcom/iris/iris_vpu_common.c | 2 +-
> 14 files changed, 32 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/iris/iris_core.h b/drivers/media/platform/qcom/iris/iris_core.h
> index d10a03aa5685..1d9a435ee747 100644
> --- a/drivers/media/platform/qcom/iris/iris_core.h
> +++ b/drivers/media/platform/qcom/iris/iris_core.h
> @@ -112,8 +112,7 @@ struct iris_core {
> u32 header_id;
> u32 packet_id;
> struct iris_core_power power;
> - const struct iris_hfi_command_ops *hfi_ops;
> - const struct iris_hfi_response_ops *hfi_response_ops;
> + const struct iris_hfi_sys_ops *hfi_sys_ops;
> struct completion core_init_done;
> u32 intr_status;
> struct delayed_work sys_error_handler;
> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_common.c b/drivers/media/platform/qcom/iris/iris_hfi_common.c
> index 92112eb16c11..ad8e4ecb8605 100644
> --- a/drivers/media/platform/qcom/iris/iris_hfi_common.c
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_common.c
> @@ -76,7 +76,7 @@ u32 iris_hfi_get_v4l2_matrix_coefficients(u32 hfi_coefficients)
>
> int iris_hfi_core_init(struct iris_core *core)
> {
> - const struct iris_hfi_command_ops *hfi_ops = core->hfi_ops;
> + const struct iris_hfi_sys_ops *hfi_ops = core->hfi_sys_ops;
> int ret;
>
> ret = hfi_ops->sys_init(core);
> @@ -109,7 +109,7 @@ irqreturn_t iris_hfi_isr_handler(int irq, void *data)
> iris_vpu_clear_interrupt(core);
> mutex_unlock(&core->lock);
>
> - core->hfi_response_ops->hfi_response_handler(core);
> + core->hfi_sys_ops->sys_hfi_response_handler(core);
>
> if (!iris_vpu_watchdog(core, core->intr_status))
> enable_irq(irq);
> @@ -144,7 +144,7 @@ int iris_hfi_pm_suspend(struct iris_core *core)
>
> int iris_hfi_pm_resume(struct iris_core *core)
> {
> - const struct iris_hfi_command_ops *ops = core->hfi_ops;
> + const struct iris_hfi_sys_ops *ops = core->hfi_sys_ops;
> int ret;
>
> ret = iris_vpu_power_on(core);
> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_common.h b/drivers/media/platform/qcom/iris/iris_hfi_common.h
> index 18684ada78b2..9aa84a1d8f95 100644
> --- a/drivers/media/platform/qcom/iris/iris_hfi_common.h
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_common.h
> @@ -105,11 +105,13 @@ struct iris_hfi_prop_type_handle {
> int (*handle)(struct iris_inst *inst, u32 plane);
> };
>
> -struct iris_hfi_command_ops {
> +struct iris_hfi_sys_ops {
> int (*sys_init)(struct iris_core *core);
> int (*sys_image_version)(struct iris_core *core);
> int (*sys_interframe_powercollapse)(struct iris_core *core);
> int (*sys_pc_prep)(struct iris_core *core);
> +
> + void (*sys_hfi_response_handler)(struct iris_core *core);
> };
>
> struct iris_hfi_session_ops {
> @@ -129,10 +131,6 @@ struct iris_hfi_session_ops {
> int (*session_close)(struct iris_inst *inst);
> };
>
> -struct iris_hfi_response_ops {
> - void (*hfi_response_handler)(struct iris_core *core);
> -};
> -
> struct hfi_subscription_params {
> u32 bitstream_resolution;
> u32 crop_offsets[2];
> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1.h b/drivers/media/platform/qcom/iris/iris_hfi_gen1.h
> index 19b8e9054a75..1c970243532a 100644
> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1.h
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1.h
> @@ -9,8 +9,8 @@
> struct iris_core;
> struct iris_inst;
>
> -void iris_hfi_gen1_command_ops_init(struct iris_core *core);
> -void iris_hfi_gen1_response_ops_init(struct iris_core *core);
> +void iris_hfi_gen1_ops_init(struct iris_core *core);
s/iris_hfi_gen1_ops_init/iris_hfi_gen1_sys_ops_init
> +void iris_hfi_gen1_response_handler(struct iris_core *core);
> struct iris_inst *iris_hfi_gen1_get_instance(void);
>
> #endif
> diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c
> index a28b0c7ebbad..eea9cc3e5904 100644
> --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c
> +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c
> @@ -1076,16 +1076,18 @@ static const struct iris_hfi_session_ops iris_hfi_gen1_session_ops = {
> .session_close = iris_hfi_gen1_session_close,
> };
>
> -static const struct iris_hfi_command_ops iris_hfi_gen1_command_ops = {
> +static const struct iris_hfi_sys_ops iris_hfi_gen1_ops = {
s/iris_hfi_gen1_ops/iris_hfi_gen1_sys_ops
to keep it consistent with hfi_gen1_session_ops.
Same comment is applicable to other places as well.
Thanks,
Dikshita
next prev parent reply other threads:[~2026-03-11 12:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 5:05 [PATCH v3 0/8] media: qcom: iris: rework platform data handling Dmitry Baryshkov
2026-03-11 5:05 ` [PATCH v3 1/8] media: qcom: iris: drop pas_id from the iris_platform_data struct Dmitry Baryshkov
2026-03-11 5:05 ` [PATCH v3 2/8] media: qcom: iris: use common set_preset_registers function Dmitry Baryshkov
2026-03-11 5:05 ` [PATCH v3 3/8] media: qcom: iris: don't use function indirection in gen2-specific code Dmitry Baryshkov
2026-03-11 5:05 ` [PATCH v3 4/8] media: qcom: iris: split HFI session ops from core ops Dmitry Baryshkov
2026-03-11 5:05 ` [PATCH v3 5/8] media: qcom: iris: merge hfi_response_ops and hfi_command_ops Dmitry Baryshkov
2026-03-11 12:18 ` Dikshita Agarwal [this message]
2026-03-11 5:05 ` [PATCH v3 6/8] media: qcom: iris: move get_instance to iris_hfi_sys_ops Dmitry Baryshkov
2026-03-11 5:05 ` [PATCH v3 7/8] media: qcom: iris: split firmware_data from raw platform data Dmitry Baryshkov
2026-03-11 5:05 ` [PATCH v3 8/8] media: qcom: iris: split platform data from firmware data Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da36d6b6-9331-4711-9c26-3f17e062219c@oss.qualcomm.com \
--to=dikshita.agarwal@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®