Re: [PATCH v3 2/2] ARM: dts: Add support for pcb8385

[Krzysztof Kozlowski <krzk@kernel.org>]

On 27/11/2025 10:24, Horatiu Vultur wrote:
> The 11/26/2025 11:24, Krzysztof Kozlowski wrote:
>>
> 
> Hi Krzysztof,
> 
>>> +
>>> +&flx0 {
>>> +     atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_TWI>;
>>> +     status = "okay";
>>> +
>>> +     i2c0: i2c@600 {
>>
>> You added a label, so this feels like a new node, but then you miss
>> compatible and status feels redundant.
> 
> Ah.. OK. I didn't want to add a new node.
> 
>>
>> If this is override, you should rather override by labels/phandles in
>> the first place. Even when overriding by full node path, you should not
>> add custom labels - they belong to the base SoC.
> 
> I can remove the label.
> So, when I want to override or extend with new properties I should
> labels?


Yes, child of serial engine should still be extended by label/phandle,
unless this SoC subsystem has different rule.

Best regards,
Krzysztof