From: "yu kuai" <yukuai@fygo.io>
To: "Tao Cui" <cui.tao@linux.dev>, <axboe@kernel.dk>,
<linux-block@vger.kernel.org>
Cc: <tj@kernel.org>, <josef@toxicpanda.com>, <yukuai3@huawei.com>,
<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Tao Cui" <cuitao@kylinos.cn>
Subject: Re: [PATCH] blk-throttle: remove dead field last_check_time from throtl_grp
Date: Sun, 2 Aug 2026 20:49:15 +0800 [thread overview]
Message-ID: <da74ba48-334f-4637-bebf-d394b72a13f7@fygo.io> (raw)
In-Reply-To: <20260717054855.2018578-1-cui.tao@linux.dev>
在 2026/7/17 13:48, Tao Cui 写道:
> From: Tao Cui<cuitao@kylinos.cn>
>
> The last_check_time field in throtl_grp was used by the
> CONFIG_BLK_DEV_THROTTLING_LOW mechanism (in throtl_upgrade_check() and
> the downgrade logic) to timestamp the last upgrade/downgrade check.
>
> Commit bf20ab538c81 ("blk-throttle: remove CONFIG_BLK_DEV_THROTTLING_LOW")
> removed all five of its uses in blk-throttle.c and the surrounding LOW
> fields (latency_target, last_finish_time, checked_last_finish_time,
> avg_idletime, idletime_threshold, bio_cnt, bad_bio_cnt,
> bio_cnt_reset_time), but missed the field definition itself.
>
> It has been a dead field since then: zero references in blk-throttle.c
> and the whole tree. Remove it.
>
> Signed-off-by: Tao Cui<cuitao@kylinos.cn>
> ---
> block/blk-throttle.h | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Yu Kuai <yukuai@fygo.io>
--
Thanks,
Kuai
next prev parent reply other threads:[~2026-08-02 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 5:48 Tao Cui
2026-07-17 11:25 ` Tang Yizhou
2026-08-02 12:49 ` yu kuai [this message]
2026-08-04 2:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da74ba48-334f-4637-bebf-d394b72a13f7@fygo.io \
--to=yukuai@fygo.io \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=cui.tao@linux.dev \
--cc=cuitao@kylinos.cn \
--cc=josef@toxicpanda.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®