Re: [PATCH] Change hex to Math::BigInt->from_hex in markup_oops.pl

[Hui Zhu <teawater@gmail.com>]

Please ignore this patch.  Because it was included in "[PATCH]
markup_oops.pl: add options to improve cross-sompilation
environments".

Thanks,
Hui

On Sun, Jan 17, 2010 at 21:36, Hui Zhu <teawater@gmail.com> wrote:
> The hex cannot work well in x86 to parse the oops message for x8664.
> So this patch change it.
>
> Thanks,
> Hui
>
> Signed-off-by: Hui Zhu <teawater@gmail.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Ozan Çaglayan <ozan@pardus.org.tr>
> Cc: Matthew Wilcox <willy@linux.intel.com>
>
> ---
>  scripts/markup_oops.pl |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/scripts/markup_oops.pl
> +++ b/scripts/markup_oops.pl
> @@ -196,7 +196,7 @@ if ($module ne "") {
>        while (<FILE>) {
>                if ($_ =~ /^([0-9a-f]+) \<$function\>\:/) {
>                        my $fu = $1;
> -                       $vmaoffset = hex($target) - hex($fu) - hex($func_offset);
> +                       $vmaoffset = Math::BigInt->from_hex("0x$target") -
> Math::BigInt->from_hex("0x$fu") -
> Math::BigInt->from_hex("0x$func_offset");
>                }
>        }
>        close(FILE);
> @@ -212,7 +212,7 @@ sub InRange {
>        my ($address, $target) = @_;
>        my $ad = "0x".$address;
>        my $ta = "0x".$target;
> -       my $delta = hex($ad) - hex($ta);
> +       my $delta = Math::BigInt->from_hex($ad) - Math::BigInt->from_hex($ta);
>
>        if (($delta > -4096) && ($delta < 4096)) {
>                return 1;
>