From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: robin@snyders.xyz, Casey Connolly <casey.connolly@linaro.org>,
Sebastian Reichel <sre@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sebastian Reichel <sebastian.reichel@collabora.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 3/5] power: supply: qcom_smbx: fix float voltage selector
Date: Mon, 17 Aug 2026 16:32:07 +0200 [thread overview]
Message-ID: <db0e8834-598a-4823-adb0-c8655d0c5dc8@oss.qualcomm.com> (raw)
In-Reply-To: <20260812-qcom-smbx-fixes-v1-3-eb48246be599@snyders.xyz>
On 8/12/26 1:30 AM, Robin Snyders via B4 Relay wrote:
> From: Robin Snyders <robin@snyders.xyz>
>
> FLOAT_VOLTAGE_CFG encodes 3,487,500 uV as selector zero and advances in
> 7,500 uV steps. The current calculation adds one to that selector, so it
> programs the requested float voltage one step too high.
>
> Remove the extra offset and name the hardware encoding constants.
>
> Fixes: 8648aeb5d7b7 ("power: supply: add Qualcomm PMI8998 SMB2 Charger driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Robin Snyders <robin@snyders.xyz>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2026-08-17 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 23:29 [PATCH 0/5] power: supply: qcom_smbx: fix watchdog and battery properties Robin Snyders via B4 Relay
2026-08-11 23:29 ` [PATCH 1/5] power: supply: qcom_smbx: include base when petting watchdog Robin Snyders via B4 Relay
2026-08-17 14:28 ` Konrad Dybcio
2026-08-11 23:29 ` [PATCH 2/5] power: supply: qcom_smbx: test battery health status bits Robin Snyders via B4 Relay
2026-08-17 14:29 ` Konrad Dybcio
2026-08-11 23:30 ` [PATCH 3/5] power: supply: qcom_smbx: fix float voltage selector Robin Snyders via B4 Relay
2026-08-17 14:32 ` Konrad Dybcio [this message]
2026-08-11 23:30 ` [PATCH 4/5] power: supply: qcom_smbx: validate battery float voltage Robin Snyders via B4 Relay
2026-08-11 23:30 ` [PATCH 5/5] power: supply: qcom_smbx: notify battery overvoltage recovery Robin Snyders via B4 Relay
2026-09-09 20:49 ` [PATCH 0/5] power: supply: qcom_smbx: fix watchdog and battery properties Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db0e8834-598a-4823-adb0-c8655d0c5dc8@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=casey.connolly@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robin@snyders.xyz \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®