mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Andrey Shumilin <shum.sdl@nppct.ru>,
	Thomas Winischhofer <thomas@winischhofer.net>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org,
	khoroshilov@ispras.ru, ykarpov@ispras.ru, vmerzlyakov@ispras.ru,
	vefanov@ispras.ru
Subject: Re: [PATCH 2/2] sis_main: Fix strbuf array overflow
Date: Sat, 28 Sep 2024 00:45:25 +0200	[thread overview]
Message-ID: <db1de78a-8846-4fbf-9923-98614f60e73a@gmx.de> (raw)
In-Reply-To: <20240927193424.3934247-1-shum.sdl@nppct.ru>

On 9/27/24 21:34, Andrey Shumilin wrote:
> The values of the variables xres and yres are placed in strbuf.
> These variables are obtained from strbuf1.
> The strbuf1 array contains digit characters
> and a space if the array contains non-digit characters.
> Then, when executing sprintf(strbuf, "%ux%ux8", xres, yres);
> more than 16 bytes will be written to strbuf.
> It is suggested to increase the size of the strbuf array to 24.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Shumilin <shum.sdl@nppct.ru>

applied to fbdev git tree.

Thanks!
Helge

> ---
>   drivers/video/fbdev/sis/sis_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
> index 03c736f6f3d0..e907fde96ff4 100644
> --- a/drivers/video/fbdev/sis/sis_main.c
> +++ b/drivers/video/fbdev/sis/sis_main.c
> @@ -183,7 +183,7 @@ static void sisfb_search_mode(char *name, bool quiet)
>   {
>   	unsigned int j = 0, xres = 0, yres = 0, depth = 0, rate = 0;
>   	int i = 0;
> -	char strbuf[16], strbuf1[20];
> +	char strbuf[24], strbuf1[20];
>   	char *nameptr = name;
>
>   	/* We don't know the hardware specs yet and there is no ivideo */


      reply	other threads:[~2024-09-27 22:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 19:34 Andrey Shumilin
2024-09-27 22:45 ` Helge Deller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db1de78a-8846-4fbf-9923-98614f60e73a@gmx.de \
    --to=deller@gmx.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=khoroshilov@ispras.ru \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=shum.sdl@nppct.ru \
    --cc=thomas@winischhofer.net \
    --cc=vefanov@ispras.ru \
    --cc=vmerzlyakov@ispras.ru \
    --cc=ykarpov@ispras.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®