mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/2] sis_main: Fix strbuf array overflow
@ 2024-09-27 19:34 Andrey Shumilin
  2024-09-27 22:45 ` Helge Deller
  0 siblings, 1 reply; 2+ messages in thread
From: Andrey Shumilin @ 2024-09-27 19:34 UTC (permalink / raw)
  To: Thomas Winischhofer
  Cc: Andrey Shumilin, Bartlomiej Zolnierkiewicz, dri-devel,
	linux-fbdev, linux-kernel, lvc-project, khoroshilov, ykarpov,
	vmerzlyakov, vefanov

The values of the variables xres and yres are placed in strbuf.
These variables are obtained from strbuf1.
The strbuf1 array contains digit characters
and a space if the array contains non-digit characters.
Then, when executing sprintf(strbuf, "%ux%ux8", xres, yres);
more than 16 bytes will be written to strbuf.
It is suggested to increase the size of the strbuf array to 24.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Andrey Shumilin <shum.sdl@nppct.ru>
---
 drivers/video/fbdev/sis/sis_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
index 03c736f6f3d0..e907fde96ff4 100644
--- a/drivers/video/fbdev/sis/sis_main.c
+++ b/drivers/video/fbdev/sis/sis_main.c
@@ -183,7 +183,7 @@ static void sisfb_search_mode(char *name, bool quiet)
 {
 	unsigned int j = 0, xres = 0, yres = 0, depth = 0, rate = 0;
 	int i = 0;
-	char strbuf[16], strbuf1[20];
+	char strbuf[24], strbuf1[20];
 	char *nameptr = name;
 
 	/* We don't know the hardware specs yet and there is no ivideo */
-- 
2.30.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2/2] sis_main: Fix strbuf array overflow
  2024-09-27 19:34 [PATCH 2/2] sis_main: Fix strbuf array overflow Andrey Shumilin
@ 2024-09-27 22:45 ` Helge Deller
  0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2024-09-27 22:45 UTC (permalink / raw)
  To: Andrey Shumilin, Thomas Winischhofer
  Cc: Bartlomiej Zolnierkiewicz, dri-devel, linux-fbdev, linux-kernel,
	lvc-project, khoroshilov, ykarpov, vmerzlyakov, vefanov

On 9/27/24 21:34, Andrey Shumilin wrote:
> The values of the variables xres and yres are placed in strbuf.
> These variables are obtained from strbuf1.
> The strbuf1 array contains digit characters
> and a space if the array contains non-digit characters.
> Then, when executing sprintf(strbuf, "%ux%ux8", xres, yres);
> more than 16 bytes will be written to strbuf.
> It is suggested to increase the size of the strbuf array to 24.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Shumilin <shum.sdl@nppct.ru>

applied to fbdev git tree.

Thanks!
Helge

> ---
>   drivers/video/fbdev/sis/sis_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
> index 03c736f6f3d0..e907fde96ff4 100644
> --- a/drivers/video/fbdev/sis/sis_main.c
> +++ b/drivers/video/fbdev/sis/sis_main.c
> @@ -183,7 +183,7 @@ static void sisfb_search_mode(char *name, bool quiet)
>   {
>   	unsigned int j = 0, xres = 0, yres = 0, depth = 0, rate = 0;
>   	int i = 0;
> -	char strbuf[16], strbuf1[20];
> +	char strbuf[24], strbuf1[20];
>   	char *nameptr = name;
>
>   	/* We don't know the hardware specs yet and there is no ivideo */


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-27 22:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-27 19:34 [PATCH 2/2] sis_main: Fix strbuf array overflow Andrey Shumilin
2024-09-27 22:45 ` Helge Deller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®