Re: [PATCH 3/5] ARM: dts: add dts files for bcmbca soc 47622

[William Zhang <william.zhang@broadcom.com>]

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]



On 4/12/22 09:27, Krzysztof Kozlowski wrote:
> On 12/04/2022 17:37, William Zhang wrote:
>>>> +/ {
>>>> +	compatible = "brcm,bcm47622";
>>>
>>> This does not match your bindings. Even if it is not used.
>> Did I miss anything? But it matches one of the compatible strings in
>> brcm,bcmbca.yaml.
> 
> Your bindings expect that this compatible is followed with "brcm,bcmbca".
> 
> (...)
Thanks! My misunderstanding.
> 
>>>> +	periph-bus@ff800000 {
>>>
>>> just "bus" to be generic?
>> This node represents the peripheral bus in the soc. Would prefer to use
>> the specific name unless it is not allowed by the linux dts.
> 
> It is allowed but the Devicetree spec explicitly asks for generic names
> and gives example: bus ("2.2.2 Generic Names Recommendation"). Specific
> names are discouraged.
Will use bus.
> 
> Best regards,
> Krzysztof

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]