[PATCH 0/2] clk: qcom: Add device tree and enable clocks for Glymur

[PATCH 0/2] clk: qcom: Add device tree and enable clocks for Glymur

[Taniya Das]

Add the Video clock controller and GPU/GX clock controllers for Glymur.
Enable the clock controllers for Glymur CRD boards.

Dependencies(Glymur DT):
https://lore.kernel.org/all/20260219-upstream_v3_glymur_introduction-v8-0-8ce4e489ebb6@oss.qualcomm.com/

Video Clock controller:
https://lore.kernel.org/all/20260202-glymur_videocc-v2-0-8f7d8b4d8edd@oss.qualcomm.com/

GPU clock controller:
https://lore.kernel.org/all/20260127-glymur_gpucc-v1-0-547334c81ba2@oss.qualcomm.com/

Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
---
Taniya Das (2):
      arm64: dts: qcom: Add support for MM clock controllers for Glymur
      arm64: defconfig: Enable Glymur clock controllers

 arch/arm64/boot/dts/qcom/glymur.dtsi | 42 ++++++++++++++++++++++++++++++++++++
 arch/arm64/configs/defconfig         |  2 ++
 2 files changed, 44 insertions(+)
---
base-commit: 44982d352c33767cd8d19f8044e7e1161a587ff7
change-id: 20260220-glymur_mmcc_dt_config-c50d9a38fe7f
prerequisite-message-id: <20260219-upstream_v3_glymur_introduction-v8-0-8ce4e489ebb6@oss.qualcomm.com>
prerequisite-patch-id: a9ccb06216435308c295e2de9adffb79060439cf
prerequisite-patch-id: 1e8d403675640d7db68a4c0caf28d1b1be895e8a
prerequisite-patch-id: 09bf515a2cd6bec5b21f15b18bebdb172f4b4a57
prerequisite-patch-id: e88699eb550ada640f5f2f5e4f432d6a3ae2552f
prerequisite-message-id: <20260127-glymur_gpucc-v1-0-547334c81ba2@oss.qualcomm.com>
prerequisite-patch-id: 6f0c175707287211c395137ca1786b2d9db82179
prerequisite-patch-id: 0b387f7c7bda3b0221057fdc053e94da4f13b60a
prerequisite-message-id: <20260202-glymur_videocc-v2-0-8f7d8b4d8edd@oss.qualcomm.com>
prerequisite-patch-id: 7bb0512ed0a2c198304d3d4064f03e0a127e8a47
prerequisite-patch-id: 0a264581e0868929c5c67c5af315220af2e838fd
prerequisite-patch-id: 4346ada14c281d949e9e25c4bccd775943aad41e
prerequisite-patch-id: 4f2f9d8ce99d2cd435021824f9a68a997c593605

Best regards,
-- 
Taniya Das <taniya.das@oss.qualcomm.com>

[PATCH 1/2] arm64: dts: qcom: Add support for MM clock controllers for Glymur

[Taniya Das]

Add the device nodes for the multimedia clock controllers videocc, gpucc
and gxclkctl.

Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/glymur.dtsi | 42 ++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
index e269cec7942c85447892c0661f83171eded94f3b..64ed707b8b24822d59e617851a35745acc366a09 100644
--- a/arch/arm64/boot/dts/qcom/glymur.dtsi
+++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
@@ -5,7 +5,10 @@
 
 #include <dt-bindings/clock/qcom,glymur-dispcc.h>
 #include <dt-bindings/clock/qcom,glymur-gcc.h>
+#include <dt-bindings/clock/qcom,glymur-gpucc.h>
 #include <dt-bindings/clock/qcom,glymur-tcsr.h>
+#include <dt-bindings/clock/qcom,glymur-videocc.h>
+#include <dt-bindings/clock/qcom,kaanapali-gxclkctl.h>
 #include <dt-bindings/clock/qcom,rpmh.h>
 #include <dt-bindings/dma/qcom-gpi.h>
 #include <dt-bindings/gpio/gpio.h>
@@ -3335,6 +3338,29 @@ hsc_noc: interconnect@2000000 {
 			#interconnect-cells = <2>;
 		};
 
+		gxclkctl: clock-controller@3d64000 {
+			compatible = "qcom,glymur-gxclkctl";
+			reg = <0x0 0x03d64000 0x0 0x6000>;
+
+			power-domains = <&rpmhpd RPMHPD_GFX>,
+					<&rpmhpd RPMHPD_GMXC>,
+					<&gpucc GPU_CC_CX_GDSC>;
+
+			#power-domain-cells = <1>;
+		};
+
+		gpucc: clock-controller@3d90000 {
+			compatible = "qcom,glymur-gpucc";
+			reg = <0x0 0x03d90000 0x0 0x9800>;
+			clocks = <&rpmhcc RPMH_CXO_CLK>,
+				<&gcc GCC_GPU_GPLL0_CLK_SRC>,
+				<&gcc GCC_GPU_GPLL0_DIV_CLK_SRC>;
+
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+			#power-domain-cells = <1>;
+		};
+
 		ipcc: mailbox@3e04000 {
 			compatible = "qcom,glymur-ipcc", "qcom,ipcc";
 			reg = <0x0 0x03e04000 0x0 0x1000>;
@@ -3367,6 +3393,22 @@ lpass_ag_noc: interconnect@7e40000 {
 			#interconnect-cells = <2>;
 		};
 
+		videocc: clock-controller@0aaf0000 {
+			compatible = "qcom,glymur-videocc";
+			reg = <0 0x0aaf0000 0 0x10000>;
+			clocks = <&rpmhcc RPMH_CXO_CLK>,
+				 <&rpmhcc RPMH_CXO_CLK_A>;
+
+			power-domains = <&rpmhpd RPMHPD_MMCX>,
+					<&rpmhpd RPMHPD_MXC>;
+			required-opps = <&rpmhpd_opp_low_svs>,
+					<&rpmhpd_opp_low_svs>;
+
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+			#power-domain-cells = <1>;
+		};
+
 		dispcc: clock-controller@af00000 {
 			compatible = "qcom,glymur-dispcc";
 			reg = <0x0 0x0af00000 0x0 0x20000>;

-- 
2.34.1

Re: [PATCH 1/2] arm64: dts: qcom: Add support for MM clock controllers for Glymur

[Konrad Dybcio]

On 2/20/26 11:16 AM, Taniya Das wrote:
> Add the device nodes for the multimedia clock controllers videocc, gpucc
> and gxclkctl.
> 
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
> ---

[...]

> +		videocc: clock-controller@0aaf0000 {

stray zero in the front

> +			compatible = "qcom,glymur-videocc";
> +			reg = <0 0x0aaf0000 0 0x10000>;

Please use 0x0 for consistency

with that:

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

[PATCH 2/2] arm64: defconfig: Enable Glymur clock controllers

[Taniya Das]

Enable the Glymur video and gpu clock controller for their respective
functionalities on the Qualcomm Glymur CRD boards.

Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index d3ed35d3e6a4f904004942ee5637a332ed8e6105..5d635e38e2af3dce417688b3acb627ea7e8d6369 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1457,7 +1457,9 @@ CONFIG_COMMON_CLK_MT8192_VENCSYS=y
 CONFIG_COMMON_CLK_QCOM=y
 CONFIG_CLK_GLYMUR_DISPCC=m
 CONFIG_CLK_GLYMUR_GCC=y
+CONFIG_CLK_GLYMUR_GPUCC=m
 CONFIG_CLK_GLYMUR_TCSRCC=m
+CONFIG_CLK_GLYMUR_VIDEOCC=m
 CONFIG_CLK_KAANAPALI_GCC=y
 CONFIG_CLK_KAANAPALI_TCSRCC=m
 CONFIG_CLK_X1E80100_CAMCC=m

-- 
2.34.1

Re: [PATCH 2/2] arm64: defconfig: Enable Glymur clock controllers

[Krzysztof Kozlowski]

On 20/02/2026 11:16, Taniya Das wrote:
> Enable the Glymur video and gpu clock controller for their respective

Qualcomm Glymur SoC

> functionalities on the Qualcomm Glymur CRD boards.

Subject: Qualcomm

Again, you are adding commit to generic kernel to generic defconfig. How
anyone can figure out what is Glymur when going via shortlog?


Best regards,
Krzysztof

Re: [PATCH 2/2] arm64: defconfig: Enable Glymur clock controllers

[Taniya Das]

On 2/20/2026 4:37 PM, Krzysztof Kozlowski wrote:
> On 20/02/2026 11:16, Taniya Das wrote:
>> Enable the Glymur video and gpu clock controller for their respective
> 
> Qualcomm Glymur SoC
> 

Sure, will update.

>> functionalities on the Qualcomm Glymur CRD boards.
> 
> Subject: Qualcomm
> 
> Again, you are adding commit to generic kernel to generic defconfig. How
> anyone can figure out what is Glymur when going via shortlog?
> 
> 
> Best regards,
> Krzysztof

-- 
Thanks,
Taniya Das

Re: [PATCH 0/2] clk: qcom: Add device tree and enable clocks for Glymur

[Dmitry Baryshkov]

On Fri, Feb 20, 2026 at 03:46:56PM +0530, Taniya Das wrote:
> Add the Video clock controller and GPU/GX clock controllers for Glymur.
> Enable the clock controllers for Glymur CRD boards.
> 
> Dependencies(Glymur DT):
> https://lore.kernel.org/all/20260219-upstream_v3_glymur_introduction-v8-0-8ce4e489ebb6@oss.qualcomm.com/
> 
> Video Clock controller:
> https://lore.kernel.org/all/20260202-glymur_videocc-v2-0-8f7d8b4d8edd@oss.qualcomm.com/
> 
> GPU clock controller:
> https://lore.kernel.org/all/20260127-glymur_gpucc-v1-0-547334c81ba2@oss.qualcomm.com/
> 
> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>

Nit: the subject for the cover letter is misleading.


-- 
With best wishes
Dmitry