From: Andrew Lunn <andrew@lunn.ch>
To: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Cc: netdev@vger.kernel.org, linux@armlinux.org.uk,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
system@metrotek.ru
Subject: Re: [PATCH net v2 2/2] net: sfp: avoid EEPROM read of absent SFP module
Date: Thu, 6 Apr 2023 16:06:12 +0200 [thread overview]
Message-ID: <db9a4f80-2ab1-48ba-84fa-322f9a5da5ec@lunn.ch> (raw)
In-Reply-To: <20230406130833.32160-3-i.bornyakov@metrotek.ru>
On Thu, Apr 06, 2023 at 04:08:33PM +0300, Ivan Bornyakov wrote:
> If SFP module is not present, it is sensible to fail sfp_module_eeprom()
> and sfp_module_eeprom_by_page() early to avoid excessive I2C transfers
> which are garanteed to fail.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2023-04-06 14:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-06 13:08 [PATCH net v2 0/2] fix " Ivan Bornyakov
2023-04-06 13:08 ` [PATCH net v2 1/2] net: sfp: initialize sfp->i2c_block_size at sfp allocation Ivan Bornyakov
2023-04-06 14:05 ` Andrew Lunn
2023-04-06 13:08 ` [PATCH net v2 2/2] net: sfp: avoid EEPROM read of absent SFP module Ivan Bornyakov
2023-04-06 14:06 ` Andrew Lunn [this message]
2023-04-09 15:10 ` [PATCH net v2 0/2] fix " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db9a4f80-2ab1-48ba-84fa-322f9a5da5ec@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=i.bornyakov@metrotek.ru \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=system@metrotek.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®