[PATCH] drivers/soc/mediatek: mark svs_resume and svs_suspend as maybe unused

[PATCH] drivers/soc/mediatek: mark svs_resume and svs_suspend as maybe unused

[Max Filippov]

This fixes the following build errors on platforms without hibernation
support in linux-next:

drivers/soc/mediatek/mtk-svs.c:1515:12: error: ‘svs_resume’ defined but not used [-Werror=unused-function]
drivers/soc/mediatek/mtk-svs.c:1481:12: error: ‘svs_suspend’ defined but not used [-Werror=unused-function]

Fixes: 681a02e95000 ("soc: mediatek: SVS: introduce MTK SVS engine")
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
 drivers/soc/mediatek/mtk-svs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index 87e05ab51552..363ab8bffa9f 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -1478,7 +1478,7 @@ static int svs_start(struct svs_platform *svsp)
 	return 0;
 }
 
-static int svs_suspend(struct device *dev)
+static int __maybe_unused svs_suspend(struct device *dev)
 {
 	struct svs_platform *svsp = dev_get_drvdata(dev);
 	struct svs_bank *svsb;
@@ -1512,7 +1512,7 @@ static int svs_suspend(struct device *dev)
 	return 0;
 }
 
-static int svs_resume(struct device *dev)
+static int __maybe_unused svs_resume(struct device *dev)
 {
 	struct svs_platform *svsp = dev_get_drvdata(dev);
 	int ret;
-- 
2.30.2

Re: [PATCH] drivers/soc/mediatek: mark svs_resume and svs_suspend as maybe unused

[AngeloGioacchino Del Regno]

Il 28/06/22 14:13, Max Filippov ha scritto:
> This fixes the following build errors on platforms without hibernation
> support in linux-next:
> 
> drivers/soc/mediatek/mtk-svs.c:1515:12: error: ‘svs_resume’ defined but not used [-Werror=unused-function]
> drivers/soc/mediatek/mtk-svs.c:1481:12: error: ‘svs_suspend’ defined but not used [-Werror=unused-function]
> 
> Fixes: 681a02e95000 ("soc: mediatek: SVS: introduce MTK SVS engine")
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>

Hello Max,

This is not the right solution... and besides, there's something else in the works;
check here:

https://patchwork.kernel.org/project/linux-mediatek/patch/20220623030931.2816013-1-jinxiaoyun2@huawei.com/

Regards,
Angelo