From: Lukasz Luba <lukasz.luba@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>, Amit Kucheria <amitk@kernel.org>
Subject: Re: [PATCH v2 3/5] thermal/drivers/devfreq_cooling: Use device name instead of auto-numbering
Date: Fri, 12 Mar 2021 18:05:24 +0000 [thread overview]
Message-ID: <dbc20126-c976-ba5d-2746-91e82fafc454@arm.com> (raw)
In-Reply-To: <20210312170316.3138-3-daniel.lezcano@linaro.org>
On 3/12/21 5:03 PM, Daniel Lezcano wrote:
> Currently the naming of a cooling device is just a cooling technique
> followed by a number. When there are multiple cooling devices using
> the same technique, it is impossible to clearly identify the related
> device as this one is just a number.
>
> For instance:
>
> thermal-devfreq-0
> thermal-devfreq-1
> etc ...
>
> The 'thermal' prefix is redundant with the subsystem namespace. This
> patch removes the 'thermal' prefix and changes the number by the device
> name. So the naming above becomes:
>
> devfreq-5000000.gpu
> devfreq-1d84000.ufshc
> etc ...
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> V2:
> - Removed idr.h header
> - Used kasprintf instead of fixed buffer length on the stack
> - Fixed typo in the log
> ---
> drivers/thermal/devfreq_cooling.c | 25 ++++++++-----------------
> 1 file changed, 8 insertions(+), 17 deletions(-)
>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
next prev parent reply other threads:[~2021-03-12 18:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 17:03 [PATCH v2 1/5] thermal/drivers/core: Use a char pointer for the cooling device name Daniel Lezcano
2021-03-12 17:03 ` [PATCH v2 2/5] thermal/drivers/cpufreq_cooling: Use device name instead of auto-numbering Daniel Lezcano
2021-03-12 17:03 ` [PATCH v2 3/5] thermal/drivers/devfreq_cooling: " Daniel Lezcano
2021-03-12 18:05 ` Lukasz Luba [this message]
2021-03-12 17:03 ` [PATCH v2 4/5] thermal/drivers/cpuidle_cooling: " Daniel Lezcano
2021-03-15 3:07 ` Viresh Kumar
2021-03-15 3:10 ` Daniel Lezcano
2021-03-12 17:03 ` [PATCH v2 5/5] thermal/drivers/cpufreq_cooling: Remove unused list Daniel Lezcano
2021-03-12 17:19 ` Lukasz Luba
2021-03-12 18:49 ` [PATCH v2 1/5] thermal/drivers/core: Use a char pointer for the cooling device name Lukasz Luba
2021-03-12 21:01 ` Daniel Lezcano
2021-03-15 9:40 ` Lukasz Luba
2021-03-15 9:58 ` Lukasz Luba
2021-03-14 9:53 ` Ido Schimmel
2021-03-14 10:48 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbc20126-c976-ba5d-2746-91e82fafc454@arm.com \
--to=lukasz.luba@arm.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®