From: Dan Carpenter <dan.carpenter@linaro.org>
To: Atharva Tiwari <evepolonium@gmail.com>
Cc: gregkh@linuxfoundation.org, elder@kernel.org,
greybus-dev@lists.linaro.org, johan@kernel.org,
linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
mgreer@animalcreek.com, vaibhav.sr@gmail.com
Subject: Re: [PATCH] staging: greybus: Remove Module from list before freeing in gb_audio_module_release
Date: Mon, 6 Jan 2025 12:51:04 +0300 [thread overview]
Message-ID: <dbdf3497-4359-4b63-b718-f53bf9ad7fc6@stanley.mountain> (raw)
In-Reply-To: <20241224051917.1971-1-evepolonium@gmail.com>
On Tue, Dec 24, 2024 at 10:49:17AM +0530, Atharva Tiwari wrote:
> Yes I have tested the patch with greybus drivers enabled on Debian 12.It works as expected, and i did not get any errors or warning during the compilation
>
> Please let me know if further changes are required.
>
You're trying to ensure that the list is initialized but instead of testing
for that, the correct way is to initialize it earlier in the process.
regards,
dan carpenter
prev parent reply other threads:[~2025-01-06 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 15:11 [PATCH] staging: greybus: Remove module " Atharva Tiwari
2024-12-23 18:05 ` Greg Kroah-Hartman
2024-12-24 5:19 ` [PATCH] staging: greybus: Remove Module " Atharva Tiwari
2024-12-24 5:43 ` Greg KH
2025-01-06 9:51 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbdf3497-4359-4b63-b718-f53bf9ad7fc6@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=elder@kernel.org \
--cc=evepolonium@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mgreer@animalcreek.com \
--cc=vaibhav.sr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®