mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nikhil Gautam <nikhilgtr@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Stefan Windfeldt-Prytz" <stefan.windfeldt-prytz@axis.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] iio: light: opt4001: Fix reversed GENMASK() arguments in fault count mask
Date: Tue, 14 Jul 2026 17:05:51 +0530	[thread overview]
Message-ID: <dbf0ea30-0fec-4c0a-a9d8-bb782b642121@gmail.com> (raw)
In-Reply-To: <alUNIpZWdSV1Q3tk@ashevche-desk.local>



On 13-07-2026 09:36 pm, Andy Shevchenko wrote:
> On Mon, Jul 13, 2026 at 09:27:33AM +0530, Nikhil Gautam wrote:
>> GENMASK(h, l) requires h >= l, but OPT4001_CTRL_FAULT_COUNT is defined
>> as GENMASK(0, 1). The define is currently unused so there is no
>> functional impact, but fix it before anyone builds on it, and add the
>> _MASK suffix for consistency with the neighbouring definitions.
> Cam you check my comments on previous version? This one seems has the same
> issues.
Yes, updated v3 by replacing tabs by spaces

Thanks,
Nikhil

  reply	other threads:[~2026-07-14 11:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13  3:57 [PATCH v2 0/4] iio: light: opt4001: Fixes from code review Nikhil Gautam
2026-07-13  3:57 ` [PATCH v2 1/4] iio: light: opt4001: Fix reversed GENMASK() arguments in fault count mask Nikhil Gautam
2026-07-13 16:06   ` Andy Shevchenko
2026-07-14 11:35     ` Nikhil Gautam [this message]
2026-07-13  3:57 ` [PATCH v2 2/4] iio: light: opt4001: Reject integration times with a non-zero seconds part Nikhil Gautam
2026-07-13  3:57 ` [PATCH v2 3/4] iio: light: opt4001: Fix incompatible pointer type passed to div_u64_rem() Nikhil Gautam
2026-07-13  3:57 ` [PATCH v2 4/4] iio: light: opt4001: Fix power down clearing bits of the wrong register Nikhil Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dbf0ea30-0fec-4c0a-a9d8-bb782b642121@gmail.com \
    --to=nikhilgtr@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=stefan.windfeldt-prytz@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox