From: Paolo Bonzini <pbonzini@redhat.com>
To: David Binderman <dcb314@hotmail.com>,
"rkrcmar@redhat.com" <rkrcmar@redhat.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: arch/x86/kvm/x86.c:7111:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
Date: Mon, 15 Jan 2018 14:32:06 +0100 [thread overview]
Message-ID: <dc06bb07-6411-219f-9094-4bc2161dbc14@redhat.com> (raw)
In-Reply-To: <HE1PR0802MB2331B0B62034607A93489D889CEB0@HE1PR0802MB2331.eurprd08.prod.outlook.com>
On 15/01/2018 13:34, David Binderman wrote:
> Hello there,
>
>
> Source code is
>
>
> switch(vcpu->arch.mp_state) {
> case KVM_MP_STATE_HALTED:
> vcpu->arch.pv.pv_unhalted = false;
> vcpu->arch.mp_state =
> KVM_MP_STATE_RUNNABLE;
> case KVM_MP_STATE_RUNNABLE:
> vcpu->arch.apf.halted = false;
> break;
>
> Suggest either add the missing break or add a fallthrough comment.
It's meant to be a fall-through to the "runnable" case (note that
mp_state becomes KVM_MP_STATE_RUNNABLE at the end of the first "case").
Would you like to post a patch yourself?
Thanks,
Paolo
>
>
> Regards
>
>
> David Binderman
>
>
parent reply other threads:[~2018-01-15 13:32 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <HE1PR0802MB2331B0B62034607A93489D889CEB0@HE1PR0802MB2331.eurprd08.prod.outlook.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc06bb07-6411-219f-9094-4bc2161dbc14@redhat.com \
--to=pbonzini@redhat.com \
--cc=dcb314@hotmail.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®