* Re: arch/x86/kvm/x86.c:7111:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
[not found] <HE1PR0802MB2331B0B62034607A93489D889CEB0@HE1PR0802MB2331.eurprd08.prod.outlook.com>
@ 2018-01-15 13:32 ` Paolo Bonzini
0 siblings, 0 replies; only message in thread
From: Paolo Bonzini @ 2018-01-15 13:32 UTC (permalink / raw)
To: David Binderman, rkrcmar, tglx, mingo, hpa, x86, kvm, linux-kernel
On 15/01/2018 13:34, David Binderman wrote:
> Hello there,
>
>
> Source code is
>
>
> switch(vcpu->arch.mp_state) {
> case KVM_MP_STATE_HALTED:
> vcpu->arch.pv.pv_unhalted = false;
> vcpu->arch.mp_state =
> KVM_MP_STATE_RUNNABLE;
> case KVM_MP_STATE_RUNNABLE:
> vcpu->arch.apf.halted = false;
> break;
>
> Suggest either add the missing break or add a fallthrough comment.
It's meant to be a fall-through to the "runnable" case (note that
mp_state becomes KVM_MP_STATE_RUNNABLE at the end of the first "case").
Would you like to post a patch yourself?
Thanks,
Paolo
>
>
> Regards
>
>
> David Binderman
>
>
^ permalink raw reply [flat|nested] only message in thread