From: Andrew Lunn <andrew@lunn.ch>
To: Jijie Shao <shaojijie@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
shenjian15@huawei.com, wangpeiyang1@huawei.com,
liuyonglong@huawei.com, chenhao418@huawei.com,
sudongming1@huawei.com, xujunsheng@huawei.com,
shiyongbang@huawei.com, libaihan@huawei.com,
jonathan.cameron@huawei.com,
shameerali.kolothum.thodi@huawei.com, salil.mehta@huawei.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 5/7] net: hibmcge: Add mac link exception handling feature in this module
Date: Thu, 13 Feb 2025 21:05:07 +0100 [thread overview]
Message-ID: <dc22a252-2889-4b20-b72c-5e4d44d24f88@lunn.ch> (raw)
In-Reply-To: <20250213035529.2402283-6-shaojijie@huawei.com>
> +int hbg_reset_phy(struct hbg_priv *priv)
> +{
> + struct phy_device *phydev = priv->mac.phydev;
> +
> + if (phydev->drv->soft_reset)
> + return phydev->drv->soft_reset(phydev);
> +
> + return genphy_soft_reset(phydev);
> +}
A MAC driver should not be doing a soft reset on a PHY. For some
devices, this clears out all the settings. I would suggest you use
phy_stop(), phy_start() which are functions a MAC driver is allowed to
use.
Andrew
next prev parent reply other threads:[~2025-02-13 20:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 3:55 [PATCH net-next 0/7] Support some enhances features for the HIBMCGE driver Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 1/7] net: hibmcge: Add dump statistics supported in this module Jijie Shao
2025-02-13 19:54 ` Andrew Lunn
2025-02-14 2:51 ` Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 2/7] net: hibmcge: Add self test " Jijie Shao
2025-02-13 19:59 ` Andrew Lunn
2025-02-14 2:46 ` Jijie Shao
2025-02-14 13:53 ` Andrew Lunn
2025-02-18 1:12 ` Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 3/7] net: hibmcge: Add rx checksum offload " Jijie Shao
2025-02-17 15:40 ` Simon Horman
2025-02-18 2:16 ` Jijie Shao
2025-02-18 2:46 ` Kalesh Anakkur Purayil
2025-02-18 8:27 ` Jijie Shao
2025-02-18 13:42 ` Simon Horman
2025-02-19 1:15 ` Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 4/7] net: hibmcge: Add abnormal irq handling feature " Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 5/7] net: hibmcge: Add mac link exception " Jijie Shao
2025-02-13 20:05 ` Andrew Lunn [this message]
2025-02-14 2:39 ` Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 6/7] net: hibmcge: Add BMC diagnose " Jijie Shao
2025-02-13 3:55 ` [PATCH net-next 7/7] net: hibmcge: Add ioctl supported " Jijie Shao
2025-02-13 20:13 ` Andrew Lunn
2025-02-14 2:30 ` Jijie Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc22a252-2889-4b20-b72c-5e4d44d24f88@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=kuba@kernel.org \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®