From: Alex Elder <elder@ieee.org>
To: Yang Yingliang <yangyingliang@huawei.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: elder@kernel.org, davem@davemloft.net, kuba@kernel.org
Subject: Re: [PATCH net-next] net: ipa: Add missing of_node_put() in ipa_firmware_load()
Date: Thu, 17 Jun 2021 05:17:23 -0500 [thread overview]
Message-ID: <dc64b44a-12a7-e5e0-1532-577d6479d7c0@ieee.org> (raw)
In-Reply-To: <20210617051119.1153120-1-yangyingliang@huawei.com>
On 6/17/21 12:11 AM, Yang Yingliang wrote:
> This node pointer is returned by of_parse_phandle() with refcount
> incremented in this function. of_node_put() on it before exiting
> this function.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Acked-by: Alex Elder <elder@linaro.org>
> ---
> drivers/net/ipa/ipa_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
> index 2243e3e5b7ea..f82130db32f6 100644
> --- a/drivers/net/ipa/ipa_main.c
> +++ b/drivers/net/ipa/ipa_main.c
> @@ -530,6 +530,7 @@ static int ipa_firmware_load(struct device *dev)
> }
>
> ret = of_address_to_resource(node, 0, &res);
> + of_node_put(node);
> if (ret) {
> dev_err(dev, "error %d getting \"memory-region\" resource\n",
> ret);
>
next prev parent reply other threads:[~2021-06-17 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 5:11 Yang Yingliang
2021-06-17 10:17 ` Alex Elder [this message]
2021-06-17 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc64b44a-12a7-e5e0-1532-577d6479d7c0@ieee.org \
--to=elder@ieee.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®