mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: mediatek: mt8390-genio-common: Add jack detection with accdet
@ 2025-03-04 21:43 Nícolas F. R. A. Prado
  2025-03-05 17:09 ` AngeloGioacchino Del Regno
  2025-04-14  9:53 ` AngeloGioacchino Del Regno
  0 siblings, 2 replies; 4+ messages in thread
From: Nícolas F. R. A. Prado @ 2025-03-04 21:43 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	AngeloGioacchino Del Regno
  Cc: kernel, devicetree, linux-kernel, linux-arm-kernel,
	linux-mediatek, Nícolas F. R. A. Prado

Enable audio jack detection for the Genio 700 and 510 EVK boards. This
is handled by the MT6359 ACCDET block, which on these boards has the
HP_EINT pin pulled high and connected to a normally open 3.5mm jack.

Add a phandle to the accdet in the sound card node so the machine sound
driver can initialize the accdet.

Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
This patch depends on both "Allow retrieving accessory detection
reference on MT8188" [1] and "Get mt6359-accdet ready for usage in
Devicetree" [2].

[1] https://lore.kernel.org/all/20250304-mt8188-accdet-v2-0-27f496c4aede@collabora.com
[2] https://lore.kernel.org/all/20250304-mt6359-accdet-dts-v3-0-5b0eafc29f5b@collabora.com
---
 arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
index 992bf60c097ae3b1fd6d4e62ef1a327b146496ef..e53c6b0b5a53a616a1684e6efc3758f449294bb9 100644
--- a/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi
@@ -1189,6 +1189,7 @@ &sound {
 		"AP DMIC", "AUDGLB",
 		"AP DMIC", "MIC_BIAS_0",
 		"AP DMIC", "MIC_BIAS_2";
+	mediatek,accdet = <&accdet>;
 	mediatek,adsp = <&adsp>;
 	status = "okay";
 

---
base-commit: 20d5c66e1810e6e8805ec0d01373afb2dba9f51a
change-id: 20250304-genio700-accdet-dts-4a4767fef27d

Best regards,
-- 
Nícolas F. R. A. Prado <nfraprado@collabora.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt8390-genio-common: Add jack detection with accdet
  2025-03-04 21:43 [PATCH] arm64: dts: mediatek: mt8390-genio-common: Add jack detection with accdet Nícolas F. R. A. Prado
@ 2025-03-05 17:09 ` AngeloGioacchino Del Regno
  2025-04-14  9:53 ` AngeloGioacchino Del Regno
  1 sibling, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-03-05 17:09 UTC (permalink / raw)
  To: Nícolas F. R. A. Prado, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Matthias Brugger
  Cc: kernel, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

Il 04/03/25 22:43, Nícolas F. R. A. Prado ha scritto:
> Enable audio jack detection for the Genio 700 and 510 EVK boards. This
> is handled by the MT6359 ACCDET block, which on these boards has the
> HP_EINT pin pulled high and connected to a normally open 3.5mm jack.
> 
> Add a phandle to the accdet in the sound card node so the machine sound
> driver can initialize the accdet.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

For the next merge cycle;

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
> This patch depends on both "Allow retrieving accessory detection
> reference on MT8188" [1] and "Get mt6359-accdet ready for usage in
> Devicetree" [2].
> 
> [1] https://lore.kernel.org/all/20250304-mt8188-accdet-v2-0-27f496c4aede@collabora.com
> [2] https://lore.kernel.org/all/20250304-mt6359-accdet-dts-v3-0-5b0eafc29f5b@collabora.com
> ---
>   arch/arm64/boot/dts/mediatek/mt8390-genio-common.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt8390-genio-common: Add jack detection with accdet
  2025-03-04 21:43 [PATCH] arm64: dts: mediatek: mt8390-genio-common: Add jack detection with accdet Nícolas F. R. A. Prado
  2025-03-05 17:09 ` AngeloGioacchino Del Regno
@ 2025-04-14  9:53 ` AngeloGioacchino Del Regno
  2025-04-15  7:26   ` AngeloGioacchino Del Regno
  1 sibling, 1 reply; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-04-14  9:53 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Nícolas F. R. A. Prado
  Cc: kernel, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

On Tue, 04 Mar 2025 18:43:49 -0300, Nícolas F. R. A. Prado wrote:
> Enable audio jack detection for the Genio 700 and 510 EVK boards. This
> is handled by the MT6359 ACCDET block, which on these boards has the
> HP_EINT pin pulled high and connected to a normally open 3.5mm jack.
> 
> Add a phandle to the accdet in the sound card node so the machine sound
> driver can initialize the accdet.
> 
> [...]

Applied to v6.15-next/dts64, thanks!

[1/1] arm64: dts: mediatek: mt8390-genio-common: Add jack detection with accdet
      commit: 691712b065d349bde7d5561aa8e1857d38b7c65a

Cheers,
Angelo



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: mediatek: mt8390-genio-common: Add jack detection with accdet
  2025-04-14  9:53 ` AngeloGioacchino Del Regno
@ 2025-04-15  7:26   ` AngeloGioacchino Del Regno
  0 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2025-04-15  7:26 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
	Nícolas F. R. A. Prado
  Cc: kernel, devicetree, linux-kernel, linux-arm-kernel, linux-mediatek

Il 14/04/25 11:53, AngeloGioacchino Del Regno ha scritto:
> On Tue, 04 Mar 2025 18:43:49 -0300, Nícolas F. R. A. Prado wrote:
>> Enable audio jack detection for the Genio 700 and 510 EVK boards. This
>> is handled by the MT6359 ACCDET block, which on these boards has the
>> HP_EINT pin pulled high and connected to a normally open 3.5mm jack.
>>
>> Add a phandle to the accdet in the sound card node so the machine sound
>> driver can initialize the accdet.
>>
>> [...]
> 
> Applied to v6.15-next/dts64, thanks!
> 
> [1/1] arm64: dts: mediatek: mt8390-genio-common: Add jack detection with accdet
>        commit: 691712b065d349bde7d5561aa8e1857d38b7c65a
> 
I dropped this as I have just acknowledged that bindings were not accepted.

Cheers,
Angelo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-04-15  7:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-04 21:43 [PATCH] arm64: dts: mediatek: mt8390-genio-common: Add jack detection with accdet Nícolas F. R. A. Prado
2025-03-05 17:09 ` AngeloGioacchino Del Regno
2025-04-14  9:53 ` AngeloGioacchino Del Regno
2025-04-15  7:26   ` AngeloGioacchino Del Regno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®