From: "Daolong Wang" <ahlongxp@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: apw@shadowen.org, rdunlap@xenotime.net, jschopp@austin.ibm.com
Subject: [PATCH]CHECKPATCH:fix misleading output on spaces/tabs error
Date: Wed, 19 Mar 2008 11:06:02 +0800 [thread overview]
Message-ID: <dc84318c0803182006u46b4ac2aj8d7a127963a0d5f3@mail.gmail.com> (raw)
I got confused by this line:
"ERROR: use tabs not spaces"
It literally means "use tabs but not spaces is WRONG", which
is WRONG.
"ERROR: do not use spaces when tabs expected"
sounds more appropriate.
Signed-off-by: Wang Daolong <ahlongxp@gmail.com>
---
--- scripts/checkpatch.pl.org 2008-03-18 23:08:41.000000000 +0800
+++ scripts/checkpatch.pl 2008-03-18 23:19:34.000000000 +0800
@@ -1064,7 +1064,7 @@ sub process {
if ($rawline =~ /^\+\s* \t\s*\S/ ||
$rawline =~ /^\+\s* \s*/) {
my $herevet = "$here\n" . cat_vet($rawline) . "\n";
- ERROR("use tabs not spaces\n" . $herevet);
+ ERROR("do not use spaces when tabs expected\n" . $herevet);
}
# check for RCS/CVS revision markers
next reply other threads:[~2008-03-19 21:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 3:06 Daolong Wang [this message]
2008-03-19 14:13 ` Andy Whitcroft
[not found] ` <dc84318c0803192108l28292288yec6f75b79aa65e80@mail.gmail.com>
2008-03-20 4:10 ` Daolong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc84318c0803182006u46b4ac2aj8d7a127963a0d5f3@mail.gmail.com \
--to=ahlongxp@gmail.com \
--cc=apw@shadowen.org \
--cc=jschopp@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®