From: "Daolong Wang" <ahlongxp@gmail.com>
To: "Andy Whitcroft" <apw@shadowen.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH]CHECKPATCH:fix misleading output on spaces/tabs error
Date: Thu, 20 Mar 2008 12:10:49 +0800 [thread overview]
Message-ID: <dc84318c0803192110xe9cc515s49350923cdc88869@mail.gmail.com> (raw)
In-Reply-To: <dc84318c0803192108l28292288yec6f75b79aa65e80@mail.gmail.com>
>
> Except that it says "use tabs not spaces when you should use tabs" and
> doesn't actually tell us what the error was, nor how to correct it. So
> its not really any better than the original (which is also useless in
> this regard).
>
> How about:
>
> "code indent should use tabs where possible"
>
>
My point is the original isn't good.
And about the replacement, that was just my suggestion.
We can choose one that'll please everyone.
In fact, either mine or yours is much better.
Add cc, Sorry for repeating.
prev parent reply other threads:[~2008-03-20 4:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 3:06 Daolong Wang
2008-03-19 14:13 ` Andy Whitcroft
[not found] ` <dc84318c0803192108l28292288yec6f75b79aa65e80@mail.gmail.com>
2008-03-20 4:10 ` Daolong Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dc84318c0803192110xe9cc515s49350923cdc88869@mail.gmail.com \
--to=ahlongxp@gmail.com \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®