* [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared
@ 2023-02-15 9:46 Lucas Tanure
2023-02-15 12:38 ` AngeloGioacchino Del Regno
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lucas Tanure @ 2023-02-15 9:46 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, Charles Keepax
Cc: alsa-devel, linux-kernel, Lucas Tanure, kernel
Add sound/pcm.h header to include struct snd_pcm_substream used in
snd_soc_dapm_update_dai function.
Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
---
include/sound/soc-dapm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/sound/soc-dapm.h b/include/sound/soc-dapm.h
index 77495e5988c1..8fbb50a11d80 100644
--- a/include/sound/soc-dapm.h
+++ b/include/sound/soc-dapm.h
@@ -14,6 +14,7 @@
#include <sound/control.h>
#include <sound/soc-topology.h>
#include <sound/asoc.h>
+#include <sound/pcm.h>
struct device;
struct snd_soc_pcm_runtime;
--
2.39.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared
2023-02-15 9:46 [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared Lucas Tanure
@ 2023-02-15 12:38 ` AngeloGioacchino Del Regno
2023-02-15 12:55 ` Charles Keepax
2023-02-15 12:58 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-02-15 12:38 UTC (permalink / raw)
To: Lucas Tanure, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Charles Keepax
Cc: alsa-devel, linux-kernel, kernel
Il 15/02/23 10:46, Lucas Tanure ha scritto:
> Add sound/pcm.h header to include struct snd_pcm_substream used in
> snd_soc_dapm_update_dai function.
>
> Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared
2023-02-15 9:46 [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared Lucas Tanure
2023-02-15 12:38 ` AngeloGioacchino Del Regno
@ 2023-02-15 12:55 ` Charles Keepax
2023-02-15 12:58 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Charles Keepax @ 2023-02-15 12:55 UTC (permalink / raw)
To: Lucas Tanure
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
alsa-devel, linux-kernel, kernel
On Wed, Feb 15, 2023 at 09:46:43AM +0000, Lucas Tanure wrote:
> Add sound/pcm.h header to include struct snd_pcm_substream used in
> snd_soc_dapm_update_dai function.
>
> Fixes: 078a85f2806f ("ASoC: dapm: Only power up active channels from a DAI")
> Signed-off-by: Lucas Tanure <lucas.tanure@collabora.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared
2023-02-15 9:46 [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared Lucas Tanure
2023-02-15 12:38 ` AngeloGioacchino Del Regno
2023-02-15 12:55 ` Charles Keepax
@ 2023-02-15 12:58 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2023-02-15 12:58 UTC (permalink / raw)
To: Lucas Tanure
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Charles Keepax,
alsa-devel, linux-kernel, kernel
[-- Attachment #1: Type: text/plain, Size: 431 bytes --]
On Wed, Feb 15, 2023 at 09:46:43AM +0000, Lucas Tanure wrote:
> Add sound/pcm.h header to include struct snd_pcm_substream used in
> snd_soc_dapm_update_dai function.
> +#include <sound/pcm.h>
>
> struct device;
> struct snd_soc_pcm_runtime;
This should be a forward declaration of the struct like the
adjacent forward declarations that are already there, we only
pass a pointer to it we don't need the contents.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-15 12:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-15 9:46 [PATCH] ASoC: soc-dapm.h: fixup warning struct snd_pcm_substream not declared Lucas Tanure
2023-02-15 12:38 ` AngeloGioacchino Del Regno
2023-02-15 12:55 ` Charles Keepax
2023-02-15 12:58 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®