[PATCH v1] arm64: defconfig: Enable Ftrace and STM configs

[PATCH v1] arm64: defconfig: Enable Ftrace and STM configs

[Mao Jinlong]

Ftrace logs can be captured by STM over TMC sink path. We can enable
ftrace logs along with HW trace of coresight component. The timestamp
of ftrace logs and hw traces will be in sync which helps to debug.

Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
---
 arch/arm64/configs/defconfig | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 4a3999eefa67..c0a56e58e554 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1554,6 +1554,12 @@ CONFIG_NVMEM_SNVS_LPGPR=y
 CONFIG_NVMEM_SPMI_SDAM=m
 CONFIG_NVMEM_SUNXI_SID=y
 CONFIG_NVMEM_UNIPHIER_EFUSE=y
+CONFIG_STM_PROTO_BASIC=m
+CONFIG_STM_PROTO_SYS_T=m
+CONFIG_STM_DUMMY=m
+CONFIG_STM_SOURCE_CONSOLE=m
+CONFIG_STM_SOURCE_HEARTBEAT=m
+CONFIG_STM_SOURCE_FTRACE=m
 CONFIG_FPGA=y
 CONFIG_FPGA_MGR_ALTERA_CVP=m
 CONFIG_FPGA_MGR_STRATIX10_SOC=m
@@ -1663,7 +1669,7 @@ CONFIG_DEBUG_INFO_REDUCED=y
 CONFIG_MAGIC_SYSRQ=y
 CONFIG_DEBUG_FS=y
 # CONFIG_SCHED_DEBUG is not set
-# CONFIG_FTRACE is not set
+CONFIG_FTRACE=y
 CONFIG_CORESIGHT=m
 CONFIG_CORESIGHT_LINK_AND_SINK_TMC=m
 CONFIG_CORESIGHT_CATU=m
-- 
2.46.0

Re: [PATCH v1] arm64: defconfig: Enable Ftrace and STM configs

[Dmitry Baryshkov]

On Fri, 20 Sept 2024 at 09:59, Mao Jinlong <quic_jinlmao@quicinc.com> wrote:
>
> Ftrace logs can be captured by STM over TMC sink path. We can enable
> ftrace logs along with HW trace of coresight component. The timestamp
> of ftrace logs and hw traces will be in sync which helps to debug.

You are describing what can be done. Please describe why this is
necessary and what is actually being done. See
Documentation/process/submitting-patches.rst. The "why" part is the
most important.

>
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
>  arch/arm64/configs/defconfig | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 4a3999eefa67..c0a56e58e554 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1554,6 +1554,12 @@ CONFIG_NVMEM_SNVS_LPGPR=y
>  CONFIG_NVMEM_SPMI_SDAM=m
>  CONFIG_NVMEM_SUNXI_SID=y
>  CONFIG_NVMEM_UNIPHIER_EFUSE=y
> +CONFIG_STM_PROTO_BASIC=m
> +CONFIG_STM_PROTO_SYS_T=m
> +CONFIG_STM_DUMMY=m
> +CONFIG_STM_SOURCE_CONSOLE=m
> +CONFIG_STM_SOURCE_HEARTBEAT=m
> +CONFIG_STM_SOURCE_FTRACE=m
>  CONFIG_FPGA=y
>  CONFIG_FPGA_MGR_ALTERA_CVP=m
>  CONFIG_FPGA_MGR_STRATIX10_SOC=m
> @@ -1663,7 +1669,7 @@ CONFIG_DEBUG_INFO_REDUCED=y
>  CONFIG_MAGIC_SYSRQ=y
>  CONFIG_DEBUG_FS=y
>  # CONFIG_SCHED_DEBUG is not set
> -# CONFIG_FTRACE is not set
> +CONFIG_FTRACE=y
>  CONFIG_CORESIGHT=m
>  CONFIG_CORESIGHT_LINK_AND_SINK_TMC=m
>  CONFIG_CORESIGHT_CATU=m
> --
> 2.46.0
>


-- 
With best wishes
Dmitry

Re: [PATCH v1] arm64: defconfig: Enable Ftrace and STM configs

[Krzysztof Kozlowski]

On 20/09/2024 09:59, Mao Jinlong wrote:
> Ftrace logs can be captured by STM over TMC sink path. We can enable
> ftrace logs along with HW trace of coresight component. The timestamp
> of ftrace logs and hw traces will be in sync which helps to debug.
> 
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
>  arch/arm64/configs/defconfig | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 

I am pretty sure I saw this and even commented on. So you miss changelog
and proper patch versioning... unless you duplicate someone's else work?

Best regards,
Krzysztof

Re: [PATCH v1] arm64: defconfig: Enable Ftrace and STM configs

[Jinlong Mao]

On 2024/9/20 16:10, Dmitry Baryshkov wrote:
> On Fri, 20 Sept 2024 at 09:59, Mao Jinlong <quic_jinlmao@quicinc.com> wrote:
>>
>> Ftrace logs can be captured by STM over TMC sink path. We can enable
>> ftrace logs along with HW trace of coresight component. The timestamp
>> of ftrace logs and hw traces will be in sync which helps to debug.
> 
> You are describing what can be done. Please describe why this is
> necessary and what is actually being done. See
> Documentation/process/submitting-patches.rst. The "why" part is the
> most important.
> 
Thanks for the review. I will update in next version.
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>> ---
>>   arch/arm64/configs/defconfig | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 4a3999eefa67..c0a56e58e554 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -1554,6 +1554,12 @@ CONFIG_NVMEM_SNVS_LPGPR=y
>>   CONFIG_NVMEM_SPMI_SDAM=m
>>   CONFIG_NVMEM_SUNXI_SID=y
>>   CONFIG_NVMEM_UNIPHIER_EFUSE=y
>> +CONFIG_STM_PROTO_BASIC=m
>> +CONFIG_STM_PROTO_SYS_T=m
>> +CONFIG_STM_DUMMY=m
>> +CONFIG_STM_SOURCE_CONSOLE=m
>> +CONFIG_STM_SOURCE_HEARTBEAT=m
>> +CONFIG_STM_SOURCE_FTRACE=m
>>   CONFIG_FPGA=y
>>   CONFIG_FPGA_MGR_ALTERA_CVP=m
>>   CONFIG_FPGA_MGR_STRATIX10_SOC=m
>> @@ -1663,7 +1669,7 @@ CONFIG_DEBUG_INFO_REDUCED=y
>>   CONFIG_MAGIC_SYSRQ=y
>>   CONFIG_DEBUG_FS=y
>>   # CONFIG_SCHED_DEBUG is not set
>> -# CONFIG_FTRACE is not set
>> +CONFIG_FTRACE=y
>>   CONFIG_CORESIGHT=m
>>   CONFIG_CORESIGHT_LINK_AND_SINK_TMC=m
>>   CONFIG_CORESIGHT_CATU=m
>> --
>> 2.46.0
>>
> 
> 

Re: [PATCH v1] arm64: defconfig: Enable Ftrace and STM configs

[Jinlong Mao]

On 2024/9/20 20:48, Krzysztof Kozlowski wrote:
> On 20/09/2024 09:59, Mao Jinlong wrote:
>> Ftrace logs can be captured by STM over TMC sink path. We can enable
>> ftrace logs along with HW trace of coresight component. The timestamp
>> of ftrace logs and hw traces will be in sync which helps to debug.
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
>> ---
>>   arch/arm64/configs/defconfig | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
> 
> I am pretty sure I saw this and even commented on. So you miss changelog
> and proper patch versioning... unless you duplicate someone's else work?

Thank you. I will correct the verion in next patch and add change logs.

> 
> Best regards,
> Krzysztof
>