From: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Andrew Ijano" <andrew.ijano@gmail.com>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
"Andy Shevchenko" <andriy.shevchenko@intel.com>
Subject: Re: [PATCH next 2/4] iio: sca3000: switch IRQ handling to devm helpers
Date: Sat, 31 Jan 2026 23:04:30 +0530 [thread overview]
Message-ID: <dd790183-8c26-405d-9583-28eb34d3d73a@oracle.com> (raw)
In-Reply-To: <20260131163011.070a80ee@jic23-huawei>
Hi Jonathan,
On 31/01/26 22:00, Jonathan Cameron wrote:
>>
>> if (spi->irq) {
>> - ret = request_threaded_irq(spi->irq,
>> - NULL,
>> + ret = devm_request_threaded_irq(dev, spi->irq, NULL,
>> &sca3000_event_handler,
> Update the indent to keep these after the (
> That is:
> ret = devm_request_threaded_irq(dev, spi->irq, NULL,
> &sca3000_event_handler,
> IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> "sca3000",
> etc
>
Oh, right, I should have indented it properly, sorry about that. I
thought checkpatch was catching these. Will fix this in a next version.
Thanks for spotting this.
Regards,
Harshit
next prev parent reply other threads:[~2026-01-31 17:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 21:43 [PATCH next 0/4] IIO: sca3000: devm resource management Harshit Mogalapalli
2026-01-30 21:43 ` [PATCH next 1/4] iio: sca3000: cache SPI device ID in probe Harshit Mogalapalli
2026-01-31 16:28 ` Jonathan Cameron
2026-01-31 17:32 ` Harshit Mogalapalli
2026-01-30 21:43 ` [PATCH next 2/4] iio: sca3000: switch IRQ handling to devm helpers Harshit Mogalapalli
2026-01-31 16:30 ` Jonathan Cameron
2026-01-31 17:34 ` Harshit Mogalapalli [this message]
2026-01-31 19:21 ` David Lechner
2026-01-31 19:28 ` Harshit Mogalapalli
2026-01-30 21:43 ` [PATCH next 3/4] iio: sca3000: manage device registration with devm helper Harshit Mogalapalli
2026-01-31 16:32 ` Jonathan Cameron
2026-01-30 21:43 ` [PATCH next 4/4] iio: sca3000: stop interrupts via devm_add_action_or_reset() Harshit Mogalapalli
2026-01-31 16:39 ` Jonathan Cameron
2026-01-31 17:52 ` Harshit Mogalapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd790183-8c26-405d-9583-28eb34d3d73a@oracle.com \
--to=harshit.m.mogalapalli@oracle.com \
--cc=andrew.ijano@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®