From: David Lechner <dlechner@baylibre.com>
To: "Harshit Mogalapalli" <harshit.m.mogalapalli@oracle.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Andrew Ijano" <andrew.ijano@gmail.com>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Cc: kernel-janitors@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@intel.com>
Subject: Re: [PATCH next 2/4] iio: sca3000: switch IRQ handling to devm helpers
Date: Sat, 31 Jan 2026 13:21:23 -0600 [thread overview]
Message-ID: <298d1c61-e6c9-4aa8-8f94-82f218ac37b5@baylibre.com> (raw)
In-Reply-To: <20260130214323.236389-3-harshit.m.mogalapalli@oracle.com>
On 1/30/26 3:43 PM, Harshit Mogalapalli wrote:
> Convert the threaded IRQ registration to devm_request_threaded_irq() so
> that the probe and remove paths can drop manual freeing of irqs.
>
> No functionality change.
>
...
> @@ -1484,23 +1483,17 @@ static int sca3000_probe(struct spi_device *spi)
> }
> ret = sca3000_clean_setup(st);
> if (ret)
> - goto error_free_irq;
> + return ret;
>
> ret = sca3000_print_rev(indio_dev);
> if (ret)
> - goto error_free_irq;
> + return ret;
>
> ret = iio_device_register(indio_dev);
> if (ret)
> - goto error_free_irq;
> + return ret;
>
> return 0;
This can `return iio_device_register();` directly now.
next prev parent reply other threads:[~2026-01-31 19:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 21:43 [PATCH next 0/4] IIO: sca3000: devm resource management Harshit Mogalapalli
2026-01-30 21:43 ` [PATCH next 1/4] iio: sca3000: cache SPI device ID in probe Harshit Mogalapalli
2026-01-31 16:28 ` Jonathan Cameron
2026-01-31 17:32 ` Harshit Mogalapalli
2026-01-30 21:43 ` [PATCH next 2/4] iio: sca3000: switch IRQ handling to devm helpers Harshit Mogalapalli
2026-01-31 16:30 ` Jonathan Cameron
2026-01-31 17:34 ` Harshit Mogalapalli
2026-01-31 19:21 ` David Lechner [this message]
2026-01-31 19:28 ` Harshit Mogalapalli
2026-01-30 21:43 ` [PATCH next 3/4] iio: sca3000: manage device registration with devm helper Harshit Mogalapalli
2026-01-31 16:32 ` Jonathan Cameron
2026-01-30 21:43 ` [PATCH next 4/4] iio: sca3000: stop interrupts via devm_add_action_or_reset() Harshit Mogalapalli
2026-01-31 16:39 ` Jonathan Cameron
2026-01-31 17:52 ` Harshit Mogalapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=298d1c61-e6c9-4aa8-8f94-82f218ac37b5@baylibre.com \
--to=dlechner@baylibre.com \
--cc=andrew.ijano@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=jic23@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®