From: Babu Moger <babu.moger@amd.com>
To: <corbet@lwn.net>, <tony.luck@intel.com>,
<reinette.chatre@intel.com>, <james.morse@arm.com>,
<tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>,
<dave.hansen@linux.intel.com>
Cc: <Dave.Martin@arm.com>, <x86@kernel.org>, <hpa@zytor.com>,
<akpm@linux-foundation.org>, <paulmck@kernel.org>,
<rostedt@goodmis.org>, <Neeraj.Upadhyay@amd.com>,
<david@redhat.com>, <arnd@arndb.de>, <fvdl@google.com>,
<seanjc@google.com>, <jpoimboe@kernel.org>,
<pawan.kumar.gupta@linux.intel.com>, <xin@zytor.com>,
<manali.shukla@amd.com>, <babu.moger@amd.com>,
<tao1.su@linux.intel.com>, <sohil.mehta@intel.com>,
<kai.huang@intel.com>, <xiaoyao.li@intel.com>,
<peterz@infradead.org>, <xin3.li@intel.com>,
<kan.liang@linux.intel.com>, <mario.limonciello@amd.com>,
<thomas.lendacky@amd.com>, <perry.yuan@amd.com>,
<gautham.shenoy@amd.com>, <chang.seok.bae@intel.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<peternewman@google.com>, <eranian@google.com>
Subject: [PATCH v16 27/34] fs/resctrl: Introduce mbm_assign_on_mkdir to enable assignments on mkdir
Date: Fri, 25 Jul 2025 13:29:46 -0500 [thread overview]
Message-ID: <dd92bf598bf7c922b212100ea668f3241f6417c0.1753467772.git.babu.moger@amd.com> (raw)
In-Reply-To: <cover.1753467772.git.babu.moger@amd.com>
The "mbm_event" counter assignment mode allows users to assign a hardware
counter to an RMID, event pair and monitor the bandwidth as long as it is
assigned.
Introduce a user-configurable option that determines if a counter will
automatically be assigned to an RMID, event pair when its associated
monitor group is created via mkdir.
Suggested-by: Peter Newman <peternewman@google.com>
Signed-off-by: Babu Moger <babu.moger@amd.com>
---
v16: Fixed the return in resctrl_mbm_assign_on_mkdir_write().
v15: Fixed the static checker warning in resctrl_mbm_assign_on_mkdir_write() reported in
https://lore.kernel.org/lkml/dd4a1021-b996-438e-941c-69dfcea5f22a@intel.com/
v14: Added rdtgroup_mutex in resctrl_mbm_assign_on_mkdir_show().
Updated resctrl.rst for clarity.
Fixed squashing of few previous changes.
Added more code documentation.
v13: Added Suggested-by tag.
Resolved conflicts caused by the recent FS/ARCH code restructure.
The rdtgroup.c/monitor.c file has now been split between the FS and ARCH directories.
v12: New patch. Added after the discussion on the list.
https://lore.kernel.org/lkml/CALPaoCh8siZKjL_3yvOYGL4cF_n_38KpUFgHVGbQ86nD+Q2_SA@mail.gmail.com/
---
Documentation/filesystems/resctrl.rst | 16 ++++++++++
fs/resctrl/monitor.c | 2 ++
fs/resctrl/rdtgroup.c | 43 +++++++++++++++++++++++++++
include/linux/resctrl.h | 3 ++
4 files changed, 64 insertions(+)
diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesystems/resctrl.rst
index 37dbad4d50f7..165e0d315af7 100644
--- a/Documentation/filesystems/resctrl.rst
+++ b/Documentation/filesystems/resctrl.rst
@@ -354,6 +354,22 @@ with the following files:
# cat /sys/fs/resctrl/info/L3_MON/event_configs/mbm_total_bytes/event_filter
local_reads,local_non_temporal_writes
+"mbm_assign_on_mkdir":
+ Determines if a counter will automatically be assigned to an RMID, event pair
+ when its associated monitor group is created via mkdir. It is enabled by default
+ on boot and users can disable by writing to the interface.
+
+ "0":
+ Auto assignment is disabled.
+ "1":
+ Auto assignment is enabled.
+
+ Example::
+
+ # echo 0 > /sys/fs/resctrl/info/L3_MON/mbm_assign_on_mkdir
+ # cat /sys/fs/resctrl/info/L3_MON/mbm_assign_on_mkdir
+ 0
+
"max_threshold_occupancy":
Read/write file provides the largest value (in
bytes) at which a previously used LLC_occupancy
diff --git a/fs/resctrl/monitor.c b/fs/resctrl/monitor.c
index 8efbeb910f77..6205bbfe08fb 100644
--- a/fs/resctrl/monitor.c
+++ b/fs/resctrl/monitor.c
@@ -1077,6 +1077,8 @@ int resctrl_mon_resource_init(void)
resctrl_file_fflags_init("available_mbm_cntrs",
RFTYPE_MON_INFO | RFTYPE_RES_CACHE);
resctrl_file_fflags_init("event_filter", RFTYPE_ASSIGN_CONFIG);
+ resctrl_file_fflags_init("mbm_assign_on_mkdir", RFTYPE_MON_INFO |
+ RFTYPE_RES_CACHE);
}
return 0;
diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
index c3d6540c3280..bf04235d2603 100644
--- a/fs/resctrl/rdtgroup.c
+++ b/fs/resctrl/rdtgroup.c
@@ -1895,6 +1895,42 @@ static int resctrl_available_mbm_cntrs_show(struct kernfs_open_file *of,
return ret;
}
+static int resctrl_mbm_assign_on_mkdir_show(struct kernfs_open_file *of,
+ struct seq_file *s, void *v)
+{
+ struct rdt_resource *r = rdt_kn_parent_priv(of->kn);
+
+ mutex_lock(&rdtgroup_mutex);
+ rdt_last_cmd_clear();
+
+ seq_printf(s, "%u\n", r->mon.mbm_assign_on_mkdir);
+
+ mutex_unlock(&rdtgroup_mutex);
+
+ return 0;
+}
+
+static ssize_t resctrl_mbm_assign_on_mkdir_write(struct kernfs_open_file *of,
+ char *buf, size_t nbytes, loff_t off)
+{
+ struct rdt_resource *r = rdt_kn_parent_priv(of->kn);
+ bool value;
+ int ret;
+
+ ret = kstrtobool(buf, &value);
+ if (ret)
+ return ret;
+
+ mutex_lock(&rdtgroup_mutex);
+ rdt_last_cmd_clear();
+
+ r->mon.mbm_assign_on_mkdir = value;
+
+ mutex_unlock(&rdtgroup_mutex);
+
+ return nbytes;
+}
+
/* rdtgroup information files for one cache resource. */
static struct rftype res_common_files[] = {
{
@@ -1904,6 +1940,13 @@ static struct rftype res_common_files[] = {
.seq_show = rdt_last_cmd_status_show,
.fflags = RFTYPE_TOP_INFO,
},
+ {
+ .name = "mbm_assign_on_mkdir",
+ .mode = 0644,
+ .kf_ops = &rdtgroup_kf_single_ops,
+ .seq_show = resctrl_mbm_assign_on_mkdir_show,
+ .write = resctrl_mbm_assign_on_mkdir_write,
+ },
{
.name = "num_closids",
.mode = 0444,
diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
index 4d37827121a6..632b9ee5466a 100644
--- a/include/linux/resctrl.h
+++ b/include/linux/resctrl.h
@@ -277,12 +277,15 @@ enum resctrl_schema_fmt {
* monitoring events can be configured.
* @num_mbm_cntrs: Number of assignable counters.
* @mbm_cntr_assignable:Is system capable of supporting counter assignment?
+ * @mbm_assign_on_mkdir:True if counters should automatically be assigned to MBM
+ * events of monitor groups created via mkdir.
*/
struct resctrl_mon {
int num_rmid;
unsigned int mbm_cfg_mask;
int num_mbm_cntrs;
bool mbm_cntr_assignable;
+ bool mbm_assign_on_mkdir;
};
/**
--
2.34.1
next prev parent reply other threads:[~2025-07-25 18:34 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 18:29 [PATCH v16 00/34] x86,fs/resctrl: Support AMD Assignable Bandwidth Monitoring Counters (ABMC) Babu Moger
2025-07-25 18:29 ` [PATCH v16 01/34] x86,fs/resctrl: Consolidate monitor event descriptions Babu Moger
2025-07-30 19:47 ` Reinette Chatre
2025-07-30 20:23 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 02/34] x86,fs/resctrl: Replace architecture event enabled checks Babu Moger
2025-07-25 18:29 ` [PATCH v16 03/34] x86/resctrl: Remove 'rdt_mon_features' global variable Babu Moger
2025-07-25 18:29 ` [PATCH v16 04/34] x86,fs/resctrl: Prepare for more monitor events Babu Moger
2025-07-25 18:29 ` [PATCH v16 05/34] x86/cpufeatures: Add support for Assignable Bandwidth Monitoring Counters (ABMC) Babu Moger
2025-07-30 19:47 ` Reinette Chatre
2025-07-25 18:29 ` [PATCH v16 06/34] x86/resctrl: Add ABMC feature in the command line options Babu Moger
2025-07-25 18:29 ` [PATCH v16 07/34] x86,fs/resctrl: Consolidate monitoring related data from rdt_resource Babu Moger
2025-07-25 18:29 ` [PATCH v16 08/34] x86,fs/resctrl: Detect Assignable Bandwidth Monitoring feature details Babu Moger
2025-07-30 19:49 ` Reinette Chatre
2025-08-06 21:04 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 09/34] x86/resctrl: Add support to enable/disable AMD ABMC feature Babu Moger
2025-07-25 18:29 ` [PATCH v16 10/34] fs/resctrl: Introduce the interface to display monitoring modes Babu Moger
2025-08-06 21:02 ` Moger, Babu
2025-08-06 21:30 ` Reinette Chatre
2025-07-25 18:29 ` [PATCH v16 11/34] fs/resctrl: Add resctrl file to display number of assignable counters Babu Moger
2025-08-06 21:12 ` Moger, Babu
2025-08-06 21:31 ` Reinette Chatre
2025-07-25 18:29 ` [PATCH v16 12/34] fs/resctrl: Introduce mbm_cntr_cfg to track assignable counters per domain Babu Moger
2025-07-25 18:29 ` [PATCH v16 13/34] fs/resctrl: Introduce interface to display number of free MBM counters Babu Moger
2025-08-06 21:19 ` Moger, Babu
2025-08-06 21:31 ` Reinette Chatre
2025-08-06 22:04 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 14/34] x86/resctrl: Add data structures and definitions for ABMC assignment Babu Moger
2025-07-25 18:29 ` [PATCH v16 15/34] fs/resctrl: Introduce event configuration field in struct mon_evt Babu Moger
2025-07-25 18:29 ` [PATCH v16 16/34] x86,fs/resctrl: Implement resctrl_arch_config_cntr() to assign a counter with ABMC Babu Moger
2025-07-30 19:50 ` Reinette Chatre
2025-07-25 18:29 ` [PATCH v16 17/34] fs/resctrl: Add the functionality to assign MBM events Babu Moger
2025-07-30 19:52 ` Reinette Chatre
2025-08-07 18:29 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 18/34] fs/resctrl: Add the functionality to unassign " Babu Moger
2025-07-30 19:53 ` Reinette Chatre
2025-08-07 18:33 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 19/34] fs/resctrl: Pass struct rdtgroup instead of individual members Babu Moger
2025-07-30 19:54 ` Reinette Chatre
2025-07-25 18:29 ` [PATCH v16 20/34] fs/resctrl: Introduce counter ID read, reset calls in mbm_event mode Babu Moger
2025-07-30 19:59 ` Reinette Chatre
2025-08-07 19:59 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 21/34] x86/resctrl: Refactor resctrl_arch_rmid_read() Babu Moger
2025-07-30 19:59 ` Reinette Chatre
2025-07-25 18:29 ` [PATCH v16 22/34] x86/resctrl: Implement resctrl_arch_reset_cntr() and resctrl_arch_cntr_read() Babu Moger
2025-07-30 20:01 ` Reinette Chatre
2025-08-08 2:05 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 23/34] fs/resctrl: Support counter read/reset with mbm_event assignment mode Babu Moger
2025-07-30 20:03 ` Reinette Chatre
2025-08-08 2:20 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 24/34] fs/resctrl: Add definitions for MBM event configuration Babu Moger
2025-07-30 20:03 ` Reinette Chatre
2025-08-08 2:24 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 25/34] fs/resctrl: Add event configuration directory under info/L3_MON/ Babu Moger
2025-07-30 20:04 ` Reinette Chatre
2025-08-08 13:56 ` Moger, Babu
2025-08-08 15:12 ` Reinette Chatre
2025-08-08 17:47 ` Moger, Babu
2025-08-08 18:23 ` Reinette Chatre
2025-08-08 18:48 ` Moger, Babu
2025-08-08 20:26 ` Reinette Chatre
2025-07-25 18:29 ` [PATCH v16 26/34] fs/resctrl: Provide interface to update the event configurations Babu Moger
2025-07-30 20:05 ` Reinette Chatre
2025-08-08 18:27 ` Moger, Babu
2025-07-25 18:29 ` Babu Moger [this message]
2025-07-30 20:08 ` [PATCH v16 27/34] fs/resctrl: Introduce mbm_assign_on_mkdir to enable assignments on mkdir Reinette Chatre
2025-08-08 20:29 ` Moger, Babu
2025-08-08 21:00 ` Reinette Chatre
2025-08-08 21:10 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 28/34] fs/resctrl: Auto assign counters on mkdir and clean up on group removal Babu Moger
2025-07-30 20:08 ` Reinette Chatre
2025-08-11 23:39 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 29/34] fs/resctrl: Introduce mbm_L3_assignments to list assignments in a group Babu Moger
2025-07-30 20:09 ` Reinette Chatre
2025-08-11 23:42 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 30/34] fs/resctrl: Introduce the interface to modify " Babu Moger
2025-07-30 20:10 ` Reinette Chatre
2025-08-11 23:51 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 31/34] fs/resctrl: Disable BMEC event configuration when mbm_event mode is enabled Babu Moger
2025-07-30 20:11 ` Reinette Chatre
2025-08-12 19:16 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 32/34] fs/resctrl: Introduce the interface to switch between monitor modes Babu Moger
2025-07-30 20:11 ` Reinette Chatre
2025-08-12 19:18 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 33/34] x86/resctrl: Configure mbm_event mode if supported Babu Moger
2025-07-30 20:11 ` Reinette Chatre
2025-08-12 19:21 ` Moger, Babu
2025-07-25 18:29 ` [PATCH v16 34/34] MAINTAINERS: resctrl: add myself as reviewer Babu Moger
2025-07-30 20:14 ` Reinette Chatre
2025-08-12 19:23 ` Moger, Babu
2025-07-30 19:47 ` [PATCH v16 00/34] x86,fs/resctrl: Support AMD Assignable Bandwidth Monitoring Counters (ABMC) Reinette Chatre
2025-07-30 23:31 ` Moger, Babu
2025-07-30 23:57 ` Reinette Chatre
2025-07-31 14:17 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd92bf598bf7c922b212100ea668f3241f6417c0.1753467772.git.babu.moger@amd.com \
--to=babu.moger@amd.com \
--cc=Dave.Martin@arm.com \
--cc=Neeraj.Upadhyay@amd.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=chang.seok.bae@intel.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=eranian@google.com \
--cc=fvdl@google.com \
--cc=gautham.shenoy@amd.com \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jpoimboe@kernel.org \
--cc=kai.huang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manali.shukla@amd.com \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=perry.yuan@amd.com \
--cc=peternewman@google.com \
--cc=peterz@infradead.org \
--cc=reinette.chatre@intel.com \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=sohil.mehta@intel.com \
--cc=tao1.su@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=xin3.li@intel.com \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®